From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E990206E8B; Fri, 8 Nov 2024 15:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731079781; cv=none; b=ZNjscCpksKS9rslfYBE1MZwOWbi7r8JNPh8juPOSWYjGm1TzXm4thk8T96DlqOIp7qnBOe98qd54Ap4frFbpUPKM/QAMJL2mMgfFl171AWKjXQ2/qFSB7O+RziD1xsmW3v19K2XkH0h0zHO1wf4kJjMGu4aFGwGka7B2+nOVEi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731079781; c=relaxed/simple; bh=OgOUF3U0a2BsZnXZXlc2ZHlVQ3+YhG5YZ5u+RpMUKiw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GYiHsYCQ2V2ddqaqly8X4hvROqFlHEeH9Flo9nyri8hh0RmCfiopmE6GWViUqJ01qHvuNxBFKQDp0o4BmJfJYYtr+Rz0aeGEPTfcVsseFq7SXbR257z2jw/NWb6PI/kvNCj7i8phWGvmpcQTVPIuCpA1HusJoUIqLtOpArhlV50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3F9CC4CECD; Fri, 8 Nov 2024 15:29:39 +0000 (UTC) Date: Fri, 8 Nov 2024 15:29:37 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kselftest/arm64: Fix build with stricter assemblers Message-ID: References: <20241108-arm64-selftest-asm-error-v1-1-7ce27b42a677@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 08, 2024 at 03:27:58PM +0000, Catalin Marinas wrote: > On Fri, Nov 08, 2024 at 03:20:46PM +0000, Mark Brown wrote: > > While some assemblers (including the LLVM assembler I mostly use) will > > happily accept SMSTART as an instruction by default others, specifically > > gas, require that any architecture extensions be explicitly enabled. > > The assembler SME test programs use manually encoded helpers for the new > > instructions but no SMSTART helper is defined, only SM and ZA specific > > variants. Unfortunately the irritators that were just added use plain > > SMSTART so on stricter assemblers these fail to build: > > > > za-test.S:160: Error: selected processor does not support `smstart' > > > > Switch to using SMSTART ZA via the manually encoded smstart_za macro we > > already have defined. > > > > Fixes: d65f27d240bb ("kselftest/arm64: Implement irritators for ZA and ZT") > > Signed-off-by: Mark Brown > > --- > > tools/testing/selftests/arm64/fp/za-test.S | 2 +- > > tools/testing/selftests/arm64/fp/zt-test.S | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/arm64/fp/za-test.S b/tools/testing/selftests/arm64/fp/za-test.S > > index 95fdc1c1f228221bc812087a528e4b7c99767bba..9c33e13e9dc4a6f084649fe7d0fb838d9171e3aa 100644 > > --- a/tools/testing/selftests/arm64/fp/za-test.S > > +++ b/tools/testing/selftests/arm64/fp/za-test.S > > @@ -157,7 +157,7 @@ function irritator_handler > > > > // This will reset ZA to all bits 0 > > smstop > > - smstart > > + smstart_za > > And is smstop ok for assemblers? I think I got the error first on > smstop with my toolchain. Ah, we already have a macro for that. Let me check the error I got, maybe I got confused (with the multitude of other warnings ;)). -- Catalin