Re: [PATCH 00/10] clockevents: Rearrange cpuhotplug operations

[Frederic Weisbecker <frederic@kernel.org>]

Le Thu, Oct 24, 2024 at 10:34:34AM +0200, Thomas Gleixner a écrit :
> On Thu, Oct 17 2024 at 18:50, Frederic Weisbecker wrote:
> > Some recent RCU issues triggered with offline ticks uncovered
> > hotplug behaviour differences between oneshot and periodic ticks.
> > The former is disabled on the dying CPU but not the latter. Also
> > the clockevents hotplug code is quite chaotic. This is a proposal to
> > fix the situation.
> 
> I like it very much!
> 
> > Frederic Weisbecker (10):
> >   clockevents: Improve clockevents_notify_released() comment
> >   clockevents: Shutdown and unregister current clockevents at
> >     CPUHP_AP_TICK_DYING
> 
> This has a build fail.

Right.

> 
> >   tick: Remove now unneeded low-res tick stop on CPUHP_AP_TICK_DYING
> >   arm/twd: Remove clockevents shutdown call on offlining
> 
> The ARM prefix preference is:
> 
>     ARM: smp_twd:
> 
> >   clocksource/drivers/arm_arch_timer: Remove clockevents shutdown call
> >     on offlining
> >   clocksource/driver/arm_global_timer: Remove clockevents shutdown call
> >     on offlining
> >   drivers/clocksource/exynos_mct: Remove clockevents shutdown call on
> >     offlining
> >   clocksource/drivers/armada-370-xp: Remove clockevents shutdown call on
> >     offlining
> >   clocksource/drivers/qcom: Remove clockevents shutdown call on
> >     offlining
> >   drivers/clocksource/timer-tegra: Remove clockevents shutdown call on
> >     offlining
> 
> Can you please make the subsystem prefixes for the clocksource drivers
> consistent 'clocksource/drivers/foo:' ?

Sure, fixing that.

Thanks!

> 
> Thanks,
> 
>         tglx