From: Sean Christopherson <seanjc@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: pbonzini@redhat.com, dmatlack@google.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] KVM: x86/mmu: Track TDP MMU NX huge pages separately
Date: Wed, 30 Oct 2024 07:25:05 -0700 [thread overview]
Message-ID: <ZyJBwQNRCFBTLQgx@google.com> (raw)
In-Reply-To: <ZyI-0cPWbbHtZQLj@google.com>
On Wed, Oct 30, 2024, Sean Christopherson wrote:
> On Fri, Sep 06, 2024, Vipin Sharma wrote:
> > + struct list_head tdp_mmu_possible_nx_huge_pages;
> > + u64 tdp_mmu_nr_possible_nx_huge_pages;
>
> These obviously come in a pair, and must be passed around as such. To make the
> relevant code easier on the eyes (long lines), and to avoid passing a mismatched
> pair, add a parent structure.
>
> E.g.
>
> struct kvm_possible_nx_huge_pages {
> struct list_head list;
Actually, I vote for s/list/pages, as that makes the usage in code is more intuitive.
> u64 nr_pages;
> }
next prev parent reply other threads:[~2024-10-30 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 20:45 [PATCH v3 0/2] KVM: x86/mmu: Run NX huge page recovery under MMU read lock Vipin Sharma
2024-09-06 20:45 ` [PATCH v3 1/2] KVM: x86/mmu: Track TDP MMU NX huge pages separately Vipin Sharma
2024-10-30 14:12 ` Sean Christopherson
2024-10-30 14:25 ` Sean Christopherson [this message]
2024-09-06 20:45 ` [PATCH v3 2/2] KVM: x86/mmu: Recover TDP MMU NX huge pages using MMU read lock Vipin Sharma
2024-09-08 23:29 ` kernel test robot
2024-09-09 16:37 ` Vipin Sharma
2024-10-30 14:28 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyJBwQNRCFBTLQgx@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox