From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577881BD9DC for ; Thu, 31 Oct 2024 03:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730347019; cv=none; b=a85+7wXQptLCz+Thhk9pqkUiKmLJ15RIQjWZdV0KUutOXj82uriKBZr+6ZEHPqf9pPzgOWHWZLTQ/h87awkvD2bHVcgzG+uMfLVlYdMW05RLukyFu1Wv7YpX6Rbud0npb+Ong94v7wyg6x+I6lv7fdS3TOdr1B0FdWrEhrutMPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730347019; c=relaxed/simple; bh=puUUnHirdOGkIP+flQZQCpVcmqzF+xFJwMhHdoeI1BQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q0jlFQ1/7/ZEQrH4A5pURfwTt1ba7Ml/SiENH2iTHR2BW7Orv4gq/bZw5VxxsVCSjMdkGIzH2YIf2mk+BfXN/Mxep9U4tTzYzZEojmbLa3SS/fxXxn8Smxqgo94b3sTPKKFz/tHNb25BoOhbRSE36HHehgWnarZnRlwNS/OM604= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Keq2akpR; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Keq2akpR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EqJ9jh64pPM8Qyg36I/QTxitIm8h1HrUf1S+E9Or9yU=; b=Keq2akpRHvVnvh8fXcYKV4XB4I ArivbGRWCw5PPatcDIuL2SbXDtgmLwd8ZDs2QcOJQ5O6Kvb3v0eeHmMV5kWw8onrxNKZLDdSKJMtA XkeqpmfM29NtRA5dX/+c8DI7CLr1/XfIjwkbQOywjZ/1feZeUej5RG8KH4WMZKy3QkIsQajutDz64 s5RaUfZFUbJWeqxZpKZnqkn4FvkSwIzPhlpElbTJaRmstOa0mnBqmsRb7LU5CcpflO2WUy4I+hVLI 02MDuG04rlpKgSAfhKFiJsOEpfju/L02RnYRvzXevXK7ccH3K2P2e3fErHDT+2A6sjv39ZGENXwKF XSl8UKAg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t6MIi-0000000EEJ7-0CBS; Thu, 31 Oct 2024 03:56:48 +0000 Date: Thu, 31 Oct 2024 03:56:47 +0000 From: Matthew Wilcox To: Kassey Li Cc: akpm@linux-foundation.org, vbabka@kernel.org, minchan@kernel.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace event Message-ID: References: <20241031024222.505844-1-quic_yingangl@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031024222.505844-1-quic_yingangl@quicinc.com> On Thu, Oct 31, 2024 at 10:42:22AM +0800, Kassey Li wrote: > This followed > commit 53d884a6675b ("mm, tracing: unify PFN format strings") > to add page info. > > In many kernel code we are talking with page other than pfn, > here we added page algin with pfn. It's generally a bad idea to print pointers to kernel memory, so no I don't like this patch.