From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] PCI/bwctrl: Check for error code from devm_mutex_init() call
Date: Thu, 31 Oct 2024 09:01:14 +0200 [thread overview]
Message-ID: <ZyMrOiW82OKcBMEi@smile.fi.intel.com> (raw)
In-Reply-To: <20241030180921.GA1210204@bhelgaas>
On Wed, Oct 30, 2024 at 01:09:21PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 30, 2024 at 06:31:39PM +0200, Andy Shevchenko wrote:
> > Even if it's not critical, the avoidance of checking the error code
> > from devm_mutex_init() call today diminishes the point of using devm
> > variant of it. Tomorrow it may even leak something. Add the missed
> > check.
> >
> > Fixes: 9b3da6e19e4d ("PCI/bwctrl: Add pcie_set_target_speed() to set PCIe Link Speed")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Squashed into 399ba413fa23 ("PCI/bwctrl: Add pcie_set_target_speed()
> to set PCIe Link Speed"), thanks, Andy.
Thanks, that works for me!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-31 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 16:31 [PATCH v1 1/1] PCI/bwctrl: Check for error code from devm_mutex_init() call Andy Shevchenko
2024-10-30 18:09 ` Bjorn Helgaas
2024-10-31 7:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyMrOiW82OKcBMEi@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox