From: Johan Hovold <johan@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/3] gpiolib: fix debugfs dangling chip separator
Date: Thu, 31 Oct 2024 18:07:55 +0100 [thread overview]
Message-ID: <ZyO5a85wq1fKD-ln@hovoldconsulting.com> (raw)
In-Reply-To: <CAMRc=Mf6yaZMsF5x=vPet=y9fa5ZTuWSAA=oi+Qw07TF8GEFbA@mail.gmail.com>
On Thu, Oct 31, 2024 at 06:02:43PM +0100, Bartosz Golaszewski wrote:
> But with this change we go from an incorrect:
>
> # cat /sys/kernel/debug/gpio
> gpiochip0: (dangling chip)
> gpiochip1: (dangling chip)
> gpiochip2: (dangling chip)root@qemux86-64:~#
>
> to still incorrect:
>
> # cat /sys/kernel/debug/gpio
> gpiochip0: (dangling chip)
>
> gpiochip1: (dangling chip)
>
> gpiochip2: (dangling chip)
Why do you think this is incorrect? Every chip section is separated by
an empty line, just as it should be:
gpiochip0: GPIOs 512-517, parent: platform/c42d000.spmi:pmic@0:gpio@8800, c42d000.spmi:pmic@0:gpio@8800:
gpio1 : in low normal vin-0 no pull push-pull low atest-1 dtest-0
gpio2 : in low normal vin-0 no pull push-pull low atest-1 dtest-0
gpio3 : out low func1 vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio4 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio5 : ---
gpio6 : in high normal vin-0 pull-up 30uA push-pull low atest-1 dtest-0
gpiochip1: GPIOs 518-529, parent: platform/c42d000.spmi:pmic@1:gpio@8800, c42d000.spmi:pmic@1:gpio@8800:
gpio1 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio2 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio3 : ---
gpio4 : ---
gpio5 : in high normal vin-0 pull-up 30uA push-pull low atest-1 dtest-0
gpio6 : in high normal vin-1 pull-up 30uA push-pull low atest-1 dtest-0
gpio7 : out high func1 vin-1 no pull push-pull low atest-1 dtest-0
gpio8 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio9 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio10: out high normal vin-1 no pull push-pull low atest-1 dtest-0
gpio11: out high normal vin-1 no pull push-pull low atest-1 dtest-0
gpio12: in low normal vin-1 pull-down 10uA push-pull low atest-1 dtest-0
gpiochip2: GPIOs 530-537, parent: platform/c42d000.spmi:pmic@2:gpio@8800, c42d000.spmi:pmic@2:gpio@8800:
gpio1 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio2 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio3 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio4 : out high normal vin-1 pull-down 10uA push-pull medium atest-1 dtest-0
gpio5 : in low normal vin-1 pull-down 10uA push-pull low atest-1 dtest-0
gpio6 : out high normal vin-1 pull-down 10uA push-pull low atest-1 dtest-0
gpio7 : in low normal vin-0 pull-down 10uA push-pull low atest-1 dtest-0
gpio8 : out low normal vin-1 pull-down 10uA push-pull low atest-1 dtest-0
Johan
next prev parent reply other threads:[~2024-10-31 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 12:49 [PATCH 0/3] gpiolib: fix debugfs newline separators Johan Hovold
2024-10-28 12:49 ` [PATCH 1/3] " Johan Hovold
2024-10-28 12:49 ` [PATCH 2/3] gpiolib: fix debugfs dangling chip separator Johan Hovold
2024-10-31 17:02 ` Bartosz Golaszewski
2024-10-31 17:07 ` Johan Hovold [this message]
2024-10-31 18:08 ` Bartosz Golaszewski
2024-10-28 12:50 ` [PATCH 3/3] gpiolib: clean up debugfs separator handling Johan Hovold
2024-10-31 18:15 ` Bartosz Golaszewski
2024-10-31 18:14 ` (subset) [PATCH 0/3] gpiolib: fix debugfs newline separators Bartosz Golaszewski
2024-11-04 7:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyO5a85wq1fKD-ln@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=johan+linaro@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox