From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65AB343AB9 for ; Fri, 1 Nov 2024 16:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730478670; cv=none; b=s9B5nOu+3yN0l1+hiBetjJHjzrJ7xGCVpbBG0kp2/8ZcubGazdyLmGOpQvKe2zLTvm59P+iXmkI6wgI/GxKU93qmNCx+YABcnnVbesmZAUMFYWqj1GXx8vQ2LxEI0QHVqJYzXJboIxi1ilCd0QMIJ1rf77hftwH9chDqllg6Cmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730478670; c=relaxed/simple; bh=aCYFBS0OlRXeeN66mv6hk1AzePNNwIISd3kE5LOhZGM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IF6/XRgnef5V8HICXxT4j6cOo7Ju03ftdAv1afW8m3hqU+giJrUGdyT44IJ2dFsHtVLUhnrQSFFQwyj9luNr85/aPqLGUbqOAkEswxUtY3ARvVDX/09n2xHx6UH9XcYqdYRBxTGKq7OlrB0ueIVqXjWZC8wQXKBjBxwamc7P7jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=3LJ3da5+; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="3LJ3da5+" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e0082c1dd0so49675847b3.3 for ; Fri, 01 Nov 2024 09:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730478667; x=1731083467; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=3LJ3da5+VnMSMaOJVtGnkKbXVzQSvLW4o0hHbA7OILbUweL6kiiES6TLw56gaunJ6Q 6Z1nyKTyIp06u+BlLB3ykq8nfFeffsPGNOl0rAZ8fCxaCYxkBrvTbxWL+GfgBaZajHYo wjA1vXy3w8qMgvr7/fBmUiiKM7nTh2xqdYMsMHkw1o1Z2+D7bOnyySPtGN1qfxUWFyyZ 6DTOv5G+cYcIyCDs4+ij8iRQRFIE7lLtrBeD7UFfkJSKNUGvZ3YhAgM3oVPLWkQW4Hrr 5rern56Tas03NIu0YpGpDDLacjUyfhCoIE06Z05fGwNJAnLOQXYZzKJmk+D2ZiT6FGKk zl0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730478667; x=1731083467; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QUMHVY5Pc5ujaPIETtg1OV7OoMZH/DlrlEhMasUvFWg=; b=fcUNaxT0pcfPL4EnG6bpDoaVnFJtqEfleQXN+HfeP0HZNjN53ZOr1tFKbtyp2yOqgv 6Kib+7JUg1kLX1VFi3+kwrSpXR+X69IeudZQ+AmNTDo3dtH3/lMHv8FimOWi6bFP8GKw yCx2rEzjY31hOQ6PQ/Q8snu5tcS+xX0Ac970Wm8aPqmpEIRsJMCk+2li52IVaqNV7iJY rdEqwtiIC6RMwa4SUrCE8R/jkkrnlhyYIEBH0qglpYesr2vXx63zXsv1/gvTmbLyfCv0 k61KAgE4ium4NcSNS3TIb3NJ0KX6coP32YxtUWODeGZZpOyCEvFWU7SbNqZr2lzZ7S9S MZiA== X-Forwarded-Encrypted: i=1; AJvYcCUJmJYdSpHqqEdLWin4Ad345+wsgI9Y6qZLh8/T+hhi4ejM++tS1YvO6bfO8uJcCB/W4kPrBjcrDugQw0c=@vger.kernel.org X-Gm-Message-State: AOJu0YzoA9y6q8hJTHQBDPCKQKiQWcs1VGmoSYaTF1cFB0bQpCnIFGPP hXYjTx6wzBxImfvEtYbNDKLah2MM70+oK6neLr8dM3ZftGk2Ojkzsc3IiBuL+FQqjYcg4PqiYjr c0g== X-Google-Smtp-Source: AGHT+IHjSky3TikiN5BvrlqT+n0lNdXJaonGgodvNxJp+r7LiGTo8fiUiA/fuWajhuo5hdeSs5DxJ2eOWac= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a25:c8c6:0:b0:e33:111b:c6a4 with SMTP id 3f1490d57ef6-e33111bc836mr1008276.1.1730478667415; Fri, 01 Nov 2024 09:31:07 -0700 (PDT) Date: Fri, 1 Nov 2024 09:31:05 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241009154953.1073471-1-seanjc@google.com> <20241009154953.1073471-4-seanjc@google.com> <39ea24d8-9dae-447a-ae37-e65878c3806f@sirena.org.uk> Message-ID: Subject: Re: [PATCH v3 03/14] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param From: Sean Christopherson To: Oliver Upton Cc: Mark Brown , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , James Houghton , David Woodhouse , linux-next@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Nov 01, 2024, Oliver Upton wrote: > On Fri, Nov 01, 2024 at 09:16:42AM -0700, Sean Christopherson wrote: > > One thing I'll add to my workflow would be to do a local merge (and smoke test) > > of linux-next into kvm-x86 next before pushing it out. This isn't the only snafu > > this cycle where such a sanity check would have saved me and others a bit of pain. > > Eh, shit happens, that's what -next is for :) Heh, but I also don't actually test -next, which was another snafu (not my fault this time!) from this cycle[*]. Testing 6.12-next prior to the merge window wouldn't have made that any less painful to bisect, but I think it would at least have allowed me to detect that the issue specifically came in from linux-next, and the bug report would have gotten to PeterZ almost two months earlier. https://lore.kernel.org/all/ZwdA0sbA2tJA3IKh@google.com