From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7191818BB93 for ; Mon, 4 Nov 2024 08:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730709499; cv=none; b=lHGAPNnmfd16uzqFe84EoSEfHfoudUPCsWYRcW9UF7UjjlOy/1bcn0PrlJzy/uZxS2ane1ucuLpFsUFB2fD7cDoBT/Ik2V+eC3gTkofbbN6YSqtIgiPPqtW2udnWKEu5KXvbQj7Wokh9CkyPw5iU/A7FE+DMMrDIHnr3ukLpnMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730709499; c=relaxed/simple; bh=G/X0h+8/yRif+x6UMM4PsGQCOAGV7mUsPioWsd9Uy1Y=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e7u4qS1lLq1mTxDnQO9hkqcvwEs2D2or4qsXZPGiqz/2IavAiLplYFovHOIKf6giwol8+EuGl248PH0Xc/tMUm7E8Ta1Cww488E6wQLerRb4CjH0DI+sWNxG37NkNfKcyc6GH2xwVURwwLo8nBWaj9vd3qipTO/3/3GwpMIPJWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SkyG/7Ua; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SkyG/7Ua" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2fb51e00c05so55105151fa.0 for ; Mon, 04 Nov 2024 00:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730709493; x=1731314293; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=0eDl7nTDHYrLpfTOtxAhIDxo7Jm/MGY+3YDpczmW7gs=; b=SkyG/7Uag6F8YZQJo1FATaSWqUNH1DRrzqdy0DIdWjXLnt8IsLjABIk6XH7CBrYKsy E/n3N9bAor8V2YJl6fl6pQRLyDVCLPjMphzXO39XwrywXwFYwso/BllS7CGpnhXVD+lG 1As12TxBzS8FBtiSUuLsSKUNk271wAiLtYm+KmA9zCVhROflG+7d9hZYZfEX3FEXW1+y ElRHtcGnXZGolSSv/r53Ao5l8uy845SmsEncYBv7SyY4tyksWGqUMHGOSkoUuFt9SIGo O8xWXMI1q8VNosdNLirSOfvyNd0eJNWEzBMIqKvVeqf1d+P/9Gy5MtM05VFy6Svp8lP4 ldUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730709493; x=1731314293; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0eDl7nTDHYrLpfTOtxAhIDxo7Jm/MGY+3YDpczmW7gs=; b=DDFPZ1/GahOcmD7G1Hi2KOw19+LkXAyMiBBBgs7NjjmYvMLAGo7fJx9X2yzM/JK9qo 1awX/wEr8Wcps9+SJfwkJNfN4Kb0pKujR2MpB8krcWFBN2nNBJPSGo0BEe5tj2GWktJH KdwJRmnpyxqJhSuK9oDu1uSHSj2uHoCGYmnX6hkc/HTNtkrj5gv7wPTEvVgx6IjTmUhu d9fCnVT7kOlwP5bQigpBtjGFF3t4mwesuDWGYAa9TBJtYIqigDKroI0IjqVLZ5EyzyT/ snWwXWC5h80l4x6dT1G7kIfP2lXaq1p97Q3UCP4i0gF4ky5aQquEQ+nMNR5pu6qyHllQ 3+jQ== X-Forwarded-Encrypted: i=1; AJvYcCVoplBD71YPzECPbw5MlNbF9xFdvq3Rq5tt21tpwQKub+js7L2OXr1KyQo/y8GplhbgqhrZja7n8iOYv9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwFLoywS9TKUlH13uaZkMj4xVd1ZLeYyR3zu5g5ECJmadVILu4v YsEhYieTqnh+k4NeyJeNyNaFZaN66OAdDzZqoMV3vCcbdR1j0s51pde7mRAYaMs= X-Google-Smtp-Source: AGHT+IFBeEZRJog8jSvCZbczChA6E0/8cPss+uc4uzyQS1f/pQYOfuO7Wtjy7JqnNnrKVyUSvAin5Q== X-Received: by 2002:a2e:a589:0:b0:2fb:3df8:6a8c with SMTP id 38308e7fff4ca-2fedb7c9c38mr69759771fa.23.1730709493472; Mon, 04 Nov 2024 00:38:13 -0800 (PST) Received: from localhost (host-79-35-211-193.retail.telecomitalia.it. [79.35.211.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e564e9ceasm522722066b.96.2024.11.04.00.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 00:38:13 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 4 Nov 2024 09:38:39 +0100 To: Herve Codina Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes Message-ID: References: <20241104090623.53f73d75@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241104090623.53f73d75@bootlin.com> Hi Herve, On 09:06 Mon 04 Nov , Herve Codina wrote: > Hi Andrea, > > On Mon, 28 Oct 2024 15:07:22 +0100 > Andrea della Porta wrote: > > > When populating "ranges" property for a PCI bridge, of_pci_prop_ranges() > > incorrectly use the CPU bus address of the resource. Since this is a PCI-PCI > > bridge, the window should instead be in PCI address space. Call > > pci_bus_address() on the resource in order to obtain the PCI bus > > address. > > > > Signed-off-by: Andrea della Porta > > Tested ok with my LAN966x PCI device. > > Tested-by: Herve Codina Thanks for testing that! Regards, Andrea > > Best regards, > Hervé