From: Johan Hovold <johan@kernel.org>
To: Qiang Yu <quic_qianyu@quicinc.com>
Cc: manivannan.sadhasivam@linaro.org, vkoul@kernel.org,
kishon@kernel.org, robh@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, abel.vesa@linaro.org,
quic_msarkar@quicinc.com, quic_devipriy@quicinc.com,
dmitry.baryshkov@linaro.org, kw@linux.com, lpieralisi@kernel.org,
neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, johan+linaro@kernel.org
Subject: Re: [PATCH v8 4/5] PCI: qcom: Disable ASPM L0s for X1E80100
Date: Mon, 4 Nov 2024 15:29:18 +0100 [thread overview]
Message-ID: <ZyjaPtGtRlsIO64b@hovoldconsulting.com> (raw)
In-Reply-To: <20241101030902.579789-5-quic_qianyu@quicinc.com>
On Thu, Oct 31, 2024 at 08:09:01PM -0700, Qiang Yu wrote:
> Currently, the cfg_1_9_0 which is being used for X1E80100 doesn't disable
> ASPM L0s. However, hardware team recommends to disable L0s as the PHY init
> sequence is not tuned support L0s. Hence reuse cfg_sc8280xp for X1E80100.
>
> Note that the config_sid() callback is not present in cfg_sc8280xp, don't
> concern about this because config_sid() callback is originally a no-op
> for X1E80100.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
This one should also have been marked for backporting:
Fixes: 6d0c39324c5f ("PCI: qcom: Add X1E80100 PCIe support")
Cc: stable@vger.kernel.org # 6.9
Looks much better now either way:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
next prev parent reply other threads:[~2024-11-04 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 3:08 [PATCH v8 0/5] Add support for PCIe3 on x1e80100 Qiang Yu
2024-11-01 3:08 ` [PATCH v8 1/5] dt-bindings: PCI: qcom: Move OPP table to qcom,pcie-common.yaml Qiang Yu
2024-11-01 3:08 ` [PATCH v8 2/5] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global' interrupt Qiang Yu
2024-11-01 3:09 ` [PATCH v8 3/5] PCI: qcom: Remove BDF2SID mapping config for SC8280X family SoC Qiang Yu
2024-11-04 14:24 ` Johan Hovold
2024-11-04 14:57 ` Krzysztof Wilczyński
2024-11-01 3:09 ` [PATCH v8 4/5] PCI: qcom: Disable ASPM L0s for X1E80100 Qiang Yu
2024-11-04 14:29 ` Johan Hovold [this message]
2024-11-04 14:59 ` Krzysztof Wilczyński
2024-11-01 3:09 ` [PATCH v8 5/5] arm64: dts: qcom: x1e80100: Add support for PCIe3 on x1e80100 Qiang Yu
2024-11-04 14:35 ` Johan Hovold
2024-11-05 5:28 ` Qiang Yu
2024-11-11 3:44 ` Qiang Yu
2024-11-12 17:29 ` Johan Hovold
2024-11-13 3:15 ` Qiang Yu
2024-11-14 15:25 ` Konrad Dybcio
2024-11-03 21:04 ` [PATCH v8 0/5] " Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyjaPtGtRlsIO64b@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_devipriy@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox