Re: [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Sun, Nov 03, 2024 at 02:49:36PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> execlists_unwind_incomplete_requests() is unused since 2021's
> commit eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC
> interface")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushed to drm-intel-gt-next

thanks for the patch.

> ---
>  drivers/gpu/drm/i915/gt/intel_engine.h               | 3 ---
>  drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 ---------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine.h b/drivers/gpu/drm/i915/gt/intel_engine.h
> index 40269e4c1e31..325da0414d94 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine.h
> +++ b/drivers/gpu/drm/i915/gt/intel_engine.h
> @@ -126,9 +126,6 @@ execlists_active(const struct intel_engine_execlists *execlists)
>  	return active;
>  }
>  
> -struct i915_request *
> -execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists);
> -
>  static inline u32
>  intel_read_status_page(const struct intel_engine_cs *engine, int reg)
>  {
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index 72090f52fb85..4a80ffa1b962 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -405,15 +405,6 @@ __unwind_incomplete_requests(struct intel_engine_cs *engine)
>  	return active;
>  }
>  
> -struct i915_request *
> -execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists)
> -{
> -	struct intel_engine_cs *engine =
> -		container_of(execlists, typeof(*engine), execlists);
> -
> -	return __unwind_incomplete_requests(engine);
> -}
> -
>  static void
>  execlists_context_status_change(struct i915_request *rq, unsigned long status)
>  {
> -- 
> 2.47.0
>