* [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests
@ 2024-11-03 14:49 linux
2024-11-04 21:32 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2024-11-03 14:49 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
simona
Cc: intel-gfx, dri-devel, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
execlists_unwind_incomplete_requests() is unused since 2021's
commit eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC
interface")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/i915/gt/intel_engine.h | 3 ---
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 ---------
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_engine.h b/drivers/gpu/drm/i915/gt/intel_engine.h
index 40269e4c1e31..325da0414d94 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine.h
+++ b/drivers/gpu/drm/i915/gt/intel_engine.h
@@ -126,9 +126,6 @@ execlists_active(const struct intel_engine_execlists *execlists)
return active;
}
-struct i915_request *
-execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists);
-
static inline u32
intel_read_status_page(const struct intel_engine_cs *engine, int reg)
{
diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
index 72090f52fb85..4a80ffa1b962 100644
--- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
@@ -405,15 +405,6 @@ __unwind_incomplete_requests(struct intel_engine_cs *engine)
return active;
}
-struct i915_request *
-execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists)
-{
- struct intel_engine_cs *engine =
- container_of(execlists, typeof(*engine), execlists);
-
- return __unwind_incomplete_requests(engine);
-}
-
static void
execlists_context_status_change(struct i915_request *rq, unsigned long status)
{
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests
2024-11-03 14:49 [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests linux
@ 2024-11-04 21:32 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2024-11-04 21:32 UTC (permalink / raw)
To: linux
Cc: jani.nikula, joonas.lahtinen, tursulin, airlied, simona,
intel-gfx, dri-devel, linux-kernel
On Sun, Nov 03, 2024 at 02:49:36PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> execlists_unwind_incomplete_requests() is unused since 2021's
> commit eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC
> interface")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushed to drm-intel-gt-next
thanks for the patch.
> ---
> drivers/gpu/drm/i915/gt/intel_engine.h | 3 ---
> drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 ---------
> 2 files changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine.h b/drivers/gpu/drm/i915/gt/intel_engine.h
> index 40269e4c1e31..325da0414d94 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine.h
> +++ b/drivers/gpu/drm/i915/gt/intel_engine.h
> @@ -126,9 +126,6 @@ execlists_active(const struct intel_engine_execlists *execlists)
> return active;
> }
>
> -struct i915_request *
> -execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists);
> -
> static inline u32
> intel_read_status_page(const struct intel_engine_cs *engine, int reg)
> {
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index 72090f52fb85..4a80ffa1b962 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -405,15 +405,6 @@ __unwind_incomplete_requests(struct intel_engine_cs *engine)
> return active;
> }
>
> -struct i915_request *
> -execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists)
> -{
> - struct intel_engine_cs *engine =
> - container_of(execlists, typeof(*engine), execlists);
> -
> - return __unwind_incomplete_requests(engine);
> -}
> -
> static void
> execlists_context_status_change(struct i915_request *rq, unsigned long status)
> {
> --
> 2.47.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-04 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-03 14:49 [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests linux
2024-11-04 21:32 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox