From: Petr Mladek <pmladek@suse.com>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
John Ogness <john.ogness@linutronix.de>,
Javier Martinez Canillas <javierm@redhat.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
bluescreen_avenger@verizon.net,
Caleb Connolly <caleb.connolly@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/6] drm/log: Implement suspend/resume
Date: Tue, 5 Nov 2024 16:08:36 +0100 [thread overview]
Message-ID: <Zyo09KEPSijfoYL4@pathway.suse.cz> (raw)
In-Reply-To: <20241105125109.226866-6-jfalempe@redhat.com>
On Tue 2024-11-05 13:42:25, Jocelyn Falempe wrote:
> Normally the console is already suspended when the graphic driver
> suspend callback is called, but if the parameter no_console_suspend
> is set, it might still be active.
> So call console_stop()/console_start() in the suspend/resume
> callbacks, to make sure it won't try to write to the framebuffer
> while the graphic driver is suspended.
>
> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Just to make it clear that I agree with this approach
for this patchset:
Acked-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
PS: I am not going to review the rest of the patchset. I believe
that John did a good job.
I actually made a quick look at the 2nd patch and the integration
with the nbcon API looked reasonable. But it was too quick look
so that my ack would not be much valuable there.
next prev parent reply other threads:[~2024-11-05 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 12:42 [PATCH v6 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen Jocelyn Falempe
2024-11-05 12:42 ` [PATCH v6 1/6] drm/panic: Move drawing functions to drm_draw Jocelyn Falempe
2024-11-05 12:42 ` [PATCH v6 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen Jocelyn Falempe
2024-11-05 13:16 ` John Ogness
2024-11-06 0:38 ` kernel test robot
2024-11-06 1:30 ` kernel test robot
2024-11-05 12:42 ` [PATCH v6 3/6] drm/log: Do not draw if drm_master is taken Jocelyn Falempe
2024-11-05 12:42 ` [PATCH v6 4/6] drm/log: Color the timestamp, to improve readability Jocelyn Falempe
2024-11-05 12:42 ` [PATCH v6 5/6] drm/log: Implement suspend/resume Jocelyn Falempe
2024-11-05 13:17 ` John Ogness
2024-11-05 15:08 ` Petr Mladek [this message]
2024-11-05 12:42 ` [PATCH v6 6/6] drm/log: Add integer scaling support Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyo09KEPSijfoYL4@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=airlied@gmail.com \
--cc=bluescreen_avenger@verizon.net \
--cc=caleb.connolly@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gpiccoli@igalia.com \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox