[PATCH] freevxfs: Replace one-element array with flexible array member

[PATCH] freevxfs: Replace one-element array with flexible array member

[Thorsten Blum]

Replace the deprecated one-element array with a modern flexible array
member in the struct vxfs_dirblk.

Link: https://github.com/KSPP/linux/issues/79
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/freevxfs/vxfs_dir.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/freevxfs/vxfs_dir.h b/fs/freevxfs/vxfs_dir.h
index fbcd603365ad..8c67627f2a3d 100644
--- a/fs/freevxfs/vxfs_dir.h
+++ b/fs/freevxfs/vxfs_dir.h
@@ -25,7 +25,7 @@
 struct vxfs_dirblk {
 	__fs16		d_free;		/* free space in dirblock */
 	__fs16		d_nhash;	/* no of hash chains */
-	__fs16		d_hash[1];	/* hash chain */
+	__fs16		d_hash[];	/* hash chain */
 };
 
 /*
-- 
2.47.0

Re: [PATCH] freevxfs: Replace one-element array with flexible array member

[Christoph Hellwig]

On Sun, Nov 03, 2024 at 01:17:09PM +0100, Thorsten Blum wrote:
> Replace the deprecated one-element array with a modern flexible array
> member in the struct vxfs_dirblk.
> 
> Link: https://github.com/KSPP/linux/issues/79
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Might be worth adding that nothing does a sizeof of the type or
variables of the type, so just hcanging it is fine.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Andrew, can you pick this up through -mm as there is no freevxfs tree?

Re: [PATCH] freevxfs: Replace one-element array with flexible array member

[Andrew Morton]

On Tue, 5 Nov 2024 03:23:06 -0800 Christoph Hellwig <hch@infradead.org> wrote:

> On Sun, Nov 03, 2024 at 01:17:09PM +0100, Thorsten Blum wrote:
> > Replace the deprecated one-element array with a modern flexible array
> > member in the struct vxfs_dirblk.
> > 
> > Link: https://github.com/KSPP/linux/issues/79
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> 
> Might be worth adding that nothing does a sizeof of the type or
> variables of the type, so just hcanging it is fine.
> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Andrew, can you pick this up through -mm as there is no freevxfs tree?

I assume Christian can scoop this up?

Re: [PATCH] freevxfs: Replace one-element array with flexible array member

[Christoph Hellwig]

On Tue, Nov 05, 2024 at 10:53:39AM -0800, Andrew Morton wrote:
> > Might be worth adding that nothing does a sizeof of the type or
> > variables of the type, so just hcanging it is fine.
> > 
> > Otherwise looks good:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > 
> > Andrew, can you pick this up through -mm as there is no freevxfs tree?
> 
> I assume Christian can scoop this up?

Fine with me :)

Re: [PATCH] freevxfs: Replace one-element array with flexible array member

[Christian Brauner]

On Sun, 03 Nov 2024 13:17:09 +0100, Thorsten Blum wrote:
> Replace the deprecated one-element array with a modern flexible array
> member in the struct vxfs_dirblk.
> 
> 

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] freevxfs: Replace one-element array with flexible array member
      https://git.kernel.org/vfs/vfs/c/fdfa4c02e6dd