From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F10D158DB2 for ; Wed, 6 Nov 2024 01:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730856787; cv=none; b=C4qS+1yzB74NzIZuAqsvVspjpJGRhp5zYbmNzE8gvetuLBRNBvWb3lTPOq9aUuCWwQTKVf4hh8CpKDjuTFSGWAjvBpvmoegqJhtPK1S6CyqUIRpyGhxNIUWKQ98V9FTkrQDuZWjqWfwC0/0Fxu/NEaYNsJp7fRLeQCUhrTbeGug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730856787; c=relaxed/simple; bh=T8TSSH9vC+xuqwWLtvuSmsWAENczxGZF4Hk4GuT1PoE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hDy1okOEx8tdS2eIy7UMPAgzGUsLG6r0KWxaFNhx2VHRRLxLwhJ+ZvD67DV+6bCPHeRoApW3BEytO1eG5vrGXVfvgWUQYxQDZCVY2jNAosImvi0K83m9SAMeTx1he0TeTKWBU6mfaFXysN+5hIrZMwM1ZwG5wmwFuvsrAqfmIAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lchHlTP9; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lchHlTP9" Date: Wed, 6 Nov 2024 01:32:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730856781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UXENiiBPrtKGHgokfuDpSrDdZeSnPcm0OZeF9aDTtlk=; b=lchHlTP9AyPGZhl8bTdCCXBeyzBTnOI/tAYx3EnNg15TY7hLErpysQZpCplkXKcBkF+6on sPJsLLggrc9CwFqVxmeBNF6u4BoqVKIFHBf0Cs76ZpAKBzf0xOZKY+SJHeR1uRCCO+USJ2 DpbgbDS3MsR+6eyUik+e6vOmE5BeTOw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Sean Christopherson Cc: Hugh Dickins , Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Matthew Wilcox , Shakeel Butt Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Tue, Nov 05, 2024 at 05:09:13PM -0800, Sean Christopherson wrote: > On Tue, Oct 22, 2024, Roman Gushchin wrote: > > On Mon, Oct 21, 2024 at 12:49:28PM -0700, Hugh Dickins wrote: > > > On Mon, 21 Oct 2024, Roman Gushchin wrote: > > > I don't think there's any need to change your text, but > > > let me remind us that any "Bad page" report stops that page from being > > > allocated again (because it's in an undefined, potentially dangerous > > > state): so does amount to a small memory leak even if otherwise harmless. > > > > It looks like I need to post v3 as soon as I get a publicly available > > syzkaller report, so I'll add this to the commit log. > > Today is your lucky day :-) I've been waiting for it for a long time :) Thanks for forwarding it my way! I'm still not sure what the conclusion of our discussion was. My understanding is that my fix is not that pretty, but there are no better immediate ideas, only long-term improvement projects. Does it matches everybody else's understanding? If so, I'll prepare a v3 with an updated link. Otherwise, please, let me know. Thanks!