From: Johan Hovold <johan@kernel.org>
To: Qiu-ji Chen <chenqiuji666@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, baijiaju1990@gmail.com
Subject: Re: [PATCH] fdti_sio: Fix atomicity violation in get_serial_info()
Date: Wed, 6 Nov 2024 15:37:10 +0100 [thread overview]
Message-ID: <Zyt_FvLvANrAA5ly@hovoldconsulting.com> (raw)
In-Reply-To: <20241106101809.17632-1-chenqiuji666@gmail.com>
On Wed, Nov 06, 2024 at 06:18:09PM +0800, Qiu-ji Chen wrote:
> Our static checker found a bug where set_serial_info() uses a mutex, but
> get_serial_info() does not. Fortunately, the impact of this is relatively
> minor. It doesn't cause a crash or any other serious issues. However, if a
> race condition occurs between set_serial_info() and get_serial_info(),
> there is a chance that the data returned by get_serial_info() will be
> meaningless.
Perhaps "inconsistent" is a better word here.
> Similar issues have been submitted or confirmed:
> https://lore.kernel.org/all/20241002125845.785464707@linuxfoundation.org/
> https://lore.kernel.org/all/20241106095819.15194-1-chenqiuji666@gmail.com/
This should go under the --- line so that it's not included in the git
logs.
> Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>
> Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()")
And please use the expected patch prefix:
USB: serial: ftdi_sio: ...
Johan
prev parent reply other threads:[~2024-11-06 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 10:18 [PATCH] fdti_sio: Fix atomicity violation in get_serial_info() Qiu-ji Chen
2024-11-06 14:37 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyt_FvLvANrAA5ly@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=baijiaju1990@gmail.com \
--cc=chenqiuji666@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox