From: Baoquan He <bhe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, dyoung@redhat.com,
daniel.kiper@oracle.com, noodles@fb.com, lijiang@redhat.com,
kexec@lists.infradead.org, x86@kernel.org
Subject: Re: [PATCH v3 1/2] x86/mm: rename the confusing local variable in early_memremap_is_setup_data()
Date: Thu, 7 Nov 2024 17:30:00 +0800 [thread overview]
Message-ID: <ZyyImAlkcpTHlszJ@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20241106112052.GCZytRFKTESZI8_3qD@fat_crate.local>
On 11/06/24 at 12:20pm, Borislav Petkov wrote:
> On Sat, Nov 02, 2024 at 12:06:18PM +0100, Borislav Petkov wrote:
> > Ok, I'll take your 2/2 next week and you can then send the cleanup ontop.
>
> OMG what a mess this is. Please test the below before I apply it.
Just got a machine and building kernel, will report here when testing is
done.
>
> Then, when you do the cleanup, do the following:
>
> - merge early_memremap_is_setup_data() with memremap_is_setup_data() into
> a common __memremap_is_setup_data() and then add a bool early which
> determines which memremap variant is called.
>
> - unify the @size argument by dropping it and using a function local size.
> What we have there now is the definition of bitrot. :-\
>
> - replace all sizeof(*data), sizeof(struct setup_data) with a macro definition
> above the functions to unify it properly.
>
> What an ugly mess... :-\
Will clean them all up as suggested. Thanks.
next prev parent reply other threads:[~2024-11-07 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 8:16 [PATCH v3 0/2] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y Baoquan He
2024-09-11 8:16 ` [PATCH v3 1/2] x86/mm: rename the confusing local variable in early_memremap_is_setup_data() Baoquan He
2024-10-29 18:11 ` Borislav Petkov
2024-10-30 0:53 ` Baoquan He
2024-10-30 12:49 ` Tom Lendacky
2024-10-31 3:41 ` Baoquan He
2024-11-01 16:18 ` Borislav Petkov
2024-11-02 0:23 ` Baoquan He
2024-11-02 11:06 ` Borislav Petkov
2024-11-06 11:20 ` Borislav Petkov
2024-11-07 9:30 ` Baoquan He [this message]
2024-11-13 12:55 ` Baoquan He
2024-11-13 13:10 ` Borislav Petkov
2024-09-11 8:16 ` [PATCH v3 2/2] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y Baoquan He
2024-11-13 13:27 ` [tip: x86/urgent] x86/mm: Fix a kdump kernel failure " tip-bot2 for Baoquan He
2024-09-30 2:59 ` [PATCH v3 0/2] x86/mm/sme: fix the kdump kernel breakage " Baoquan He
2024-10-29 7:20 ` Baoquan He
2024-10-30 1:23 ` Andrew Morton
2024-10-30 2:54 ` Baoquan He
2024-10-30 11:31 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyyImAlkcpTHlszJ@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=daniel.kiper@oracle.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@fb.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox