[PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly

[PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

While working on the wakeup functionality of a RTC driver, I noticed
that we have a few occasions where 'pm_wakeup.h' gets included directly
despite the comment that it shouldn't be done. It doesn't build-break
because these files also include 'device.h' either directly or via some
indirection, mostly 'platform_device.h'. Still, respect the requirement
that 'pm_wakeup.h' shall only be included in 'device.h' and not
directly.

Based on 6.12-rc7. Build-bot is happy and there are no dependencies. I
suggest that each patch goes in via the relevant subsystem tree.

Thanks and happy hacking,

   Wolfram


Wolfram Sang (15):
  x86/platform/olpc-xo1-sci: don't include 'pm_wakeup.h' directly
  drivers core: don't include 'pm_wakeup.h' directly
  HID: google: don't include 'pm_wakeup.h' directly
  coresight: etm4x: don't include 'pm_wakeup.h' directly
  Input: spear-keyboard - don't include 'pm_wakeup.h' directly
  Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly
  media: mceusb: don't include 'pm_wakeup.h' directly
  mmc: core: don't include 'pm_wakeup.h' directly
  net: phy: broadcom: don't include 'pm_wakeup.h' directly
  net: wwan: t7xx: don't include 'pm_wakeup.h' directly
  PCI: don't include 'pm_wakeup.h' directly
  platform/x86: quickstart: don't include 'pm_wakeup.h' directly
  rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly
  usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly
  PM / Sleep: don't include 'pm_wakeup.h' directly

 arch/x86/platform/olpc/olpc-xo1-sci.c              | 1 -
 drivers/base/power/sysfs.c                         | 1 -
 drivers/hid/hid-google-hammer.c                    | 1 -
 drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
 drivers/input/keyboard/spear-keyboard.c            | 1 -
 drivers/input/keyboard/sun4i-lradc-keys.c          | 1 -
 drivers/media/rc/mceusb.c                          | 1 -
 drivers/mmc/core/core.c                            | 1 -
 drivers/mmc/core/host.c                            | 1 -
 drivers/net/phy/broadcom.c                         | 2 +-
 drivers/net/wwan/t7xx/t7xx_pci.c                   | 1 -
 drivers/pci/pci.c                                  | 1 -
 drivers/platform/x86/quickstart.c                  | 1 -
 drivers/rtc/rtc-brcmstb-waketimer.c                | 1 -
 drivers/usb/typec/tcpm/tcpci_mt6370.c              | 1 -
 kernel/power/autosleep.c                           | 1 -
 16 files changed, 1 insertion(+), 16 deletions(-)

-- 
2.39.2

[PATCH 01/15] x86/platform/olpc-xo1-sci: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/x86/platform/olpc/olpc-xo1-sci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/platform/olpc/olpc-xo1-sci.c b/arch/x86/platform/olpc/olpc-xo1-sci.c
index 46d42ff6e18a..36aad8cf97a0 100644
--- a/arch/x86/platform/olpc/olpc-xo1-sci.c
+++ b/arch/x86/platform/olpc/olpc-xo1-sci.c
@@ -14,7 +14,6 @@
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/pm.h>
-#include <linux/pm_wakeup.h>
 #include <linux/power_supply.h>
 #include <linux/suspend.h>
 #include <linux/workqueue.h>
-- 
2.39.2

[PATCH 02/15] drivers core: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/base/power/sysfs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/base/power/sysfs.c b/drivers/base/power/sysfs.c
index a1474fb67db9..82ce2d9f54e5 100644
--- a/drivers/base/power/sysfs.c
+++ b/drivers/base/power/sysfs.c
@@ -6,7 +6,6 @@
 #include <linux/export.h>
 #include <linux/pm_qos.h>
 #include <linux/pm_runtime.h>
-#include <linux/pm_wakeup.h>
 #include <linux/atomic.h>
 #include <linux/jiffies.h>
 #include "power.h"
-- 
2.39.2

[PATCH 03/15] HID: google: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/hid/hid-google-hammer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 22683ec819aa..1be4366f740f 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -22,7 +22,6 @@
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
 #include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
 #include <linux/unaligned.h>
 
 #include "hid-ids.h"
-- 
2.39.2

[PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
index 66d44a404ad0..559972a00fdf 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
@@ -23,7 +23,6 @@
 #include <linux/cpu_pm.h>
 #include <linux/coresight.h>
 #include <linux/coresight-pmu.h>
-#include <linux/pm_wakeup.h>
 #include <linux/amba/bus.h>
 #include <linux/seq_file.h>
 #include <linux/uaccess.h>
-- 
2.39.2

[PATCH 05/15] Input: spear-keyboard - don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/input/keyboard/spear-keyboard.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index 1df4feb8ba01..18417ba19fdb 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -20,7 +20,6 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
 #include <linux/slab.h>
 #include <linux/types.h>
 #include <linux/platform_data/keyboard-spear.h>
-- 
2.39.2

[PATCH 06/15] Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/input/keyboard/sun4i-lradc-keys.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index f304cab0ebdb..9a4fdef2650e 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -24,7 +24,6 @@
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pm_wakeirq.h>
-#include <linux/pm_wakeup.h>
 #include <linux/property.h>
 #include <linux/regulator/consumer.h>
 #include <linux/reset.h>
-- 
2.39.2

[PATCH 07/15] media: mceusb: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/media/rc/mceusb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index cd7af4d88b7f..7e824eb2db9f 100644
--- a/drivers/media/rc/mceusb.c
+++ b/drivers/media/rc/mceusb.c
@@ -28,7 +28,6 @@
 #include <linux/workqueue.h>
 #include <linux/usb.h>
 #include <linux/usb/input.h>
-#include <linux/pm_wakeup.h>
 #include <media/rc-core.h>
 
 #define DRIVER_VERSION	"1.95"
-- 
2.39.2

[PATCH 08/15] mmc: core: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/core/core.c | 1 -
 drivers/mmc/core/host.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index d6c819dd68ed..c877dae8b4e2 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -19,7 +19,6 @@
 #include <linux/scatterlist.h>
 #include <linux/log2.h>
 #include <linux/pm_runtime.h>
-#include <linux/pm_wakeup.h>
 #include <linux/suspend.h>
 #include <linux/fault-inject.h>
 #include <linux/random.h>
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 48bda70145ee..bdb22998357e 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -14,7 +14,6 @@
 #include <linux/idr.h>
 #include <linux/of.h>
 #include <linux/pagemap.h>
-#include <linux/pm_wakeup.h>
 #include <linux/export.h>
 #include <linux/leds.h>
 #include <linux/slab.h>
-- 
2.39.2

[PATCH 09/15] net: phy: broadcom: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/net/phy/broadcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index ddded162c44c..5b55137c9d55 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -16,7 +16,7 @@
 #include <linux/delay.h>
 #include <linux/module.h>
 #include <linux/phy.h>
-#include <linux/pm_wakeup.h>
+#include <linux/device.h>
 #include <linux/brcmphy.h>
 #include <linux/of.h>
 #include <linux/interrupt.h>
-- 
2.39.2

[PATCH 10/15] net: wwan: t7xx: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/net/wwan/t7xx/t7xx_pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wwan/t7xx/t7xx_pci.c b/drivers/net/wwan/t7xx/t7xx_pci.c
index e556e5bd49ab..5ce169461c7b 100644
--- a/drivers/net/wwan/t7xx/t7xx_pci.c
+++ b/drivers/net/wwan/t7xx/t7xx_pci.c
@@ -32,7 +32,6 @@
 #include <linux/pci.h>
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
-#include <linux/pm_wakeup.h>
 #include <linux/spinlock.h>
 
 #include "t7xx_mhccif.h"
-- 
2.39.2

[PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/pci/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 225a6cd2e9ca..3b1939c9cf46 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -23,7 +23,6 @@
 #include <linux/string.h>
 #include <linux/log2.h>
 #include <linux/logic_pio.h>
-#include <linux/pm_wakeup.h>
 #include <linux/device.h>
 #include <linux/pm_runtime.h>
 #include <linux/pci_hotplug.h>
-- 
2.39.2

[PATCH 12/15] platform/x86: quickstart: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/platform/x86/quickstart.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c
index 8d540a1c8602..c332c7cdaff5 100644
--- a/drivers/platform/x86/quickstart.c
+++ b/drivers/platform/x86/quickstart.c
@@ -20,7 +20,6 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
 #include <linux/printk.h>
 #include <linux/slab.h>
 #include <linux/sysfs.h>
-- 
2.39.2

[PATCH 13/15] rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/rtc/rtc-brcmstb-waketimer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c
index 1a65a4e0dc00..6c7701b24ba5 100644
--- a/drivers/rtc/rtc-brcmstb-waketimer.c
+++ b/drivers/rtc/rtc-brcmstb-waketimer.c
@@ -17,7 +17,6 @@
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pm.h>
-#include <linux/pm_wakeup.h>
 #include <linux/reboot.h>
 #include <linux/rtc.h>
 #include <linux/stat.h>
-- 
2.39.2

[PATCH 14/15] usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
index 9cda1005ef01..bc5fd2557e6f 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
@@ -11,7 +11,6 @@
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
 #include <linux/pm_wakeirq.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
-- 
2.39.2

[PATCH 15/15] PM / Sleep: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 kernel/power/autosleep.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/power/autosleep.c b/kernel/power/autosleep.c
index b29c8aca7486..865df641b97c 100644
--- a/kernel/power/autosleep.c
+++ b/kernel/power/autosleep.c
@@ -9,7 +9,6 @@
 
 #include <linux/device.h>
 #include <linux/mutex.h>
-#include <linux/pm_wakeup.h>
 
 #include "power.h"
 
-- 
2.39.2

Re: [PATCH 03/15] HID: google: don't include 'pm_wakeup.h' directly

[Jiri Kosina]

On Mon, 18 Nov 2024, Wolfram Sang wrote:

> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Jiri Kosina <jkosina@suse.com>

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly

[Suzuki K Poulose]

On 18/11/2024 07:29, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 66d44a404ad0..559972a00fdf 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -23,7 +23,6 @@
>   #include <linux/cpu_pm.h>
>   #include <linux/coresight.h>
>   #include <linux/coresight-pmu.h>
> -#include <linux/pm_wakeup.h>
>   #include <linux/amba/bus.h>
>   #include <linux/seq_file.h>
>   #include <linux/uaccess.h>

If you plan to take this as a collection outside of CoreSight tree,

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Otherwise, I can pick this up.


Suzuki

Re: (subset) [PATCH 13/15] rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly

[Alexandre Belloni]

On Mon, 18 Nov 2024 08:29:12 +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> 

Applied, thanks!

[13/15] rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly
        https://git.kernel.org/abelloni/c/5b42edefd733

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]


> If you plan to take this as a collection outside of CoreSight tree,
> 
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
> Otherwise, I can pick this up.

As stated in the cover letter, please pick it up. There are no
dependencies.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 10/15] net: wwan: t7xx: don't include 'pm_wakeup.h' directly

[Sergey Ryazanov]

On 18.11.2024 09:29, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

Re: [PATCH 09/15] net: phy: broadcom: don't include 'pm_wakeup.h' directly

[Florian Fainelli]

On 11/17/24 23:29, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Re: [PATCH 14/15] usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly

[Heikki Krogerus]

On Mon, Nov 18, 2024 at 08:29:13AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 9cda1005ef01..bc5fd2557e6f 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -11,7 +11,6 @@
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/pm_wakeirq.h>
>  #include <linux/regmap.h>
>  #include <linux/regulator/consumer.h>
> -- 
> 2.39.2

-- 
heikki

Re: [PATCH 05/15] Input: spear-keyboard - don't include 'pm_wakeup.h' directly

[Dmitry Torokhov]

On Mon, Nov 18, 2024 at 08:29:04AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied, thank you.

-- 
Dmitry

Re: [PATCH 06/15] Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly

[Dmitry Torokhov]

On Mon, Nov 18, 2024 at 08:29:05AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied, thank you.

-- 
Dmitry

Re: [PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly

[Bjorn Helgaas]

On Mon, Nov 18, 2024 at 08:29:10AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I plan to pick this up for v6.14 as soon as the v6.13 merge window
closes.

> ---
>  drivers/pci/pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 225a6cd2e9ca..3b1939c9cf46 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -23,7 +23,6 @@
>  #include <linux/string.h>
>  #include <linux/log2.h>
>  #include <linux/logic_pio.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/pci_hotplug.h>
> -- 
> 2.39.2
> 

Re: [PATCH 08/15] mmc: core: don't include 'pm_wakeup.h' directly

[Ulf Hansson]

On Mon, 18 Nov 2024 at 08:29, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/core.c | 1 -
>  drivers/mmc/core/host.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index d6c819dd68ed..c877dae8b4e2 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -19,7 +19,6 @@
>  #include <linux/scatterlist.h>
>  #include <linux/log2.h>
>  #include <linux/pm_runtime.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/suspend.h>
>  #include <linux/fault-inject.h>
>  #include <linux/random.h>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 48bda70145ee..bdb22998357e 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -14,7 +14,6 @@
>  #include <linux/idr.h>
>  #include <linux/of.h>
>  #include <linux/pagemap.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/export.h>
>  #include <linux/leds.h>
>  #include <linux/slab.h>
> --
> 2.39.2
>

Re: [PATCH 12/15] platform/x86: quickstart: don't include 'pm_wakeup.h' directly

[Ilpo Järvinen]

On Mon, 18 Nov 2024, Wolfram Sang wrote:

> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/platform/x86/quickstart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c
> index 8d540a1c8602..c332c7cdaff5 100644
> --- a/drivers/platform/x86/quickstart.c
> +++ b/drivers/platform/x86/quickstart.c
> @@ -20,7 +20,6 @@
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/platform_device.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/printk.h>
>  #include <linux/slab.h>
>  #include <linux/sysfs.h>

Thanks for the patch. I've applied it to the review-ilpo-next branch in 
the pdx86 repo.

-- 
 i.

Re: [PATCH 15/15] PM / Sleep: don't include 'pm_wakeup.h' directly

[Rafael J. Wysocki]

On Mon, Nov 18, 2024 at 8:30 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  kernel/power/autosleep.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/power/autosleep.c b/kernel/power/autosleep.c
> index b29c8aca7486..865df641b97c 100644
> --- a/kernel/power/autosleep.c
> +++ b/kernel/power/autosleep.c
> @@ -9,7 +9,6 @@
>
>  #include <linux/device.h>
>  #include <linux/mutex.h>
> -#include <linux/pm_wakeup.h>
>
>  #include "power.h"
>
> --

Applied as 6.14 material, thanks!

Re: [PATCH 02/15] drivers core: don't include 'pm_wakeup.h' directly

[Rafael J. Wysocki]

On Mon, Nov 18, 2024 at 8:29 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/base/power/sysfs.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/power/sysfs.c b/drivers/base/power/sysfs.c
> index a1474fb67db9..82ce2d9f54e5 100644
> --- a/drivers/base/power/sysfs.c
> +++ b/drivers/base/power/sysfs.c
> @@ -6,7 +6,6 @@
>  #include <linux/export.h>
>  #include <linux/pm_qos.h>
>  #include <linux/pm_runtime.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/atomic.h>
>  #include <linux/jiffies.h>
>  #include "power.h"
> --

Applied as 6.14 material, thanks!

Re: [PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly

[Krzysztof Wilczyński]

Hello,

> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.

Applied to misc, thank you!

[01/01] PCI: Don't include 'pm_wakeup.h' directly
        https://git.kernel.org/pci/pci/c/cd3e4149e2f6

	Krzysztof