From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EB4B1714A3; Wed, 20 Nov 2024 20:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732134960; cv=none; b=u79sGg8TUmpMF/klyw5u0u8mg8E7SDWyFKQRJJ8llA7AG+voK5GHsGXmExAfJjhR5F/XF2ZVLzuQ3SZxM8FlBkRdqEJuLbETqdUe40mNeAwkjCxY25MngjAOuBY9dbB/VSPIttkBHFNdg0ZaAQhgYe7ynLcbsX092U+dNMFiK7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732134960; c=relaxed/simple; bh=X8FBbRmWHmatSWLjM3YTpUV6jfXsVQ1VgIdJpMCHcSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UMPw1GNKPkDKztEUb2m8Uz5XorSc1fOoBkryclFPCNk0493iW2Cf/fQwW078awykzqq8uGsjj7s7scOivltdngjy5uxshLZdTm3VjKlx9lRjmIU0ZfCqAfYojZsXJBGBAX+rHxArUr/aprEhbFcwHYxjR3g8Uj8Vwm2uTnWi+8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OBfA9xir; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OBfA9xir" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE34FC4CECD; Wed, 20 Nov 2024 20:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732134960; bh=X8FBbRmWHmatSWLjM3YTpUV6jfXsVQ1VgIdJpMCHcSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OBfA9xirbzJPWJpZLOMX09UWwftrmYuI3LnpqOoOmNI+yN/pwtdXwdRijCyKD41tj x9XosnvE4MzG+d7U0fy9SKkJOF/yaQWlUUh4Z2UWhe5D8hWEo+/gnZJyHPHaBnZym4 T8qVA851O6RjQT1ntRxz6orvEA4ujSWeZt9Pkhw89zdBbDGzqlOWjZJItAJqJlxcvO BJP7xbSW7HUI1SYGTgM69fKtb0GvpGKvzOzaOUNLknAM/hTOM9Yxpt/P6puRZLKgWL rPm6QBeSDRXrMDaxw2bsDTub280IUEXTOQQ38g+bZoWNlyuz6LPtq7Cz6kSrsotXdg Z1IwIYaZWJluA== Date: Wed, 20 Nov 2024 20:35:58 +0000 From: Jaegeuk Kim To: Chao Yu Cc: Eric Sandeen , Daniel Rosenberg , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] Revert "f2fs: remove unreachable lazytime mount option parsing" Message-ID: References: <20241112010820.2788822-1-jaegeuk@kernel.org> <2d26eeee-01f7-445b-a1d2-bc2de65b5599@kernel.org> <35c20e47-9124-45df-8067-67c5ef29600e@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35c20e47-9124-45df-8067-67c5ef29600e@kernel.org> On 11/20, Chao Yu wrote: > On 2024/11/20 4:48, Jaegeuk Kim wrote: > > On 11/19, Chao Yu wrote: > > > On 2024/11/13 5:39, Jaegeuk Kim via Linux-f2fs-devel wrote: > > > > Hi Eric, > > > > > > > > Could you please check this revert as it breaks the mount()? > > > > It seems F2FS needs to implement new mount support. > > > > > > Hi all, > > > > > > Actually, if we want to enable lazytime option, we can use mount > > > syscall as: > > > > > > mount("/dev/vdb", "/mnt/test", "f2fs", MS_LAZYTIME, NULL); > > > > > > or use shell script as: > > > > > > mount -t f2fs -o lazytime /dev/vdb /mnt/test > > > > > > IIUC, the reason why mount command can handle lazytime is, after > > > 8c7f073aaeaa ("libmount: add support for MS_LAZYTIME"), mount command > > > supports to map "lazytime" to MS_LAZYTIME, and use MS_LAZYTIME in > > > parameter @mountflags of mount(2). > > > > > > So, it looks we have alternative way to enable/disable lazytime feature > > > after removing Opt_{no,}lazytime parsing in f2fs, do we really need this > > > revert patch? > > > > This is a regression of the below command. I don't think offering others are > > feasible. > > > > mount("/dev/vdb", "/mnt/test", "f2fs", 0, "lazytime"); > > Alright, there are other options were removed along w/ removal of > related feature. e.g. > > 1. io_bits=%u by commit 87161a2b0aed ("f2fs: deprecate io_bits") > 2. whint_mode=%s by commit 930e2607638d ("f2fs: remove obsolete whint_mode") > > Do we need to add these options handling back, and print "xxx options were > deprecated" as we did in ("f2fs: kill heap-based allocation"), in order to > avoid mount(......, "io_bits=%u" or "whint_mode=%s") command regression? These are different from the generic lazytime option, and I haven't got any complaint on this removal. > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 867b147eb957..329f317e6f09 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -733,10 +733,8 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) > clear_opt(sbi, DISCARD); > break; > case Opt_noheap: > - set_opt(sbi, NOHEAP); > - break; > case Opt_heap: > - clear_opt(sbi, NOHEAP); > + f2fs_warn(sbi, "heap/no_heap options were deprecated"); > break; > > Thanks, > > > > > > > > > Thanks, > > > > > > > > > > > Thanks, > > > > > > > > On 11/12, Jaegeuk Kim wrote: > > > > > This reverts commit 54f43a10fa257ad4af02a1d157fefef6ebcfa7dc. > > > > > > > > > > The above commit broke the lazytime mount, given > > > > > > > > > > mount("/dev/vdb", "/mnt/test", "f2fs", 0, "lazytime"); > > > > > > > > > > CC: stable@vger.kernel.org # 6.11+ > > > > > Signed-off-by: Daniel Rosenberg > > > > > Signed-off-by: Jaegeuk Kim > > > > > --- > > > > > fs/f2fs/super.c | 10 ++++++++++ > > > > > 1 file changed, 10 insertions(+) > > > > > > > > > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > > > > > index 49519439b770..35c4394e4fc6 100644 > > > > > --- a/fs/f2fs/super.c > > > > > +++ b/fs/f2fs/super.c > > > > > @@ -150,6 +150,8 @@ enum { > > > > > Opt_mode, > > > > > Opt_fault_injection, > > > > > Opt_fault_type, > > > > > + Opt_lazytime, > > > > > + Opt_nolazytime, > > > > > Opt_quota, > > > > > Opt_noquota, > > > > > Opt_usrquota, > > > > > @@ -226,6 +228,8 @@ static match_table_t f2fs_tokens = { > > > > > {Opt_mode, "mode=%s"}, > > > > > {Opt_fault_injection, "fault_injection=%u"}, > > > > > {Opt_fault_type, "fault_type=%u"}, > > > > > + {Opt_lazytime, "lazytime"}, > > > > > + {Opt_nolazytime, "nolazytime"}, > > > > > {Opt_quota, "quota"}, > > > > > {Opt_noquota, "noquota"}, > > > > > {Opt_usrquota, "usrquota"}, > > > > > @@ -922,6 +926,12 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) > > > > > f2fs_info(sbi, "fault_type options not supported"); > > > > > break; > > > > > #endif > > > > > + case Opt_lazytime: > > > > > + sb->s_flags |= SB_LAZYTIME; > > > > > + break; > > > > > + case Opt_nolazytime: > > > > > + sb->s_flags &= ~SB_LAZYTIME; > > > > > + break; > > > > > #ifdef CONFIG_QUOTA > > > > > case Opt_quota: > > > > > case Opt_usrquota: > > > > > -- > > > > > 2.47.0.277.g8800431eea-goog > > > > > > > > > > > > _______________________________________________ > > > > Linux-f2fs-devel mailing list > > > > Linux-f2fs-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel