From: "Ragavendra B.N." <ragavendra.bn@gmail.com>
To: Chen Wang <unicorn_wang@outlook.com>,
mturquette@baylibre.com, sboyd@kernel.org, inochiama@outlook.com,
ragavendra.bn@gmail.com
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk:sophgo:clk-cv18xx-pll: fix unitialized u32 variable
Date: Thu, 14 Nov 2024 12:04:23 -0800 [thread overview]
Message-ID: <ZzZXxxSghLGy_mZf@desktop> (raw)
In-Reply-To: <MA0P287MB2822D976E1A3379DEAC28666FE5A2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
On Thu, Nov 14, 2024 at 07:36:21AM +0800, Chen Wang wrote:
> Hi, Ragavendra,
>
> This patch should be dropped, right? I see a new patch https://lore.kernel.org/linux-clk/20241113184617.3745423-1-ragavendra.bn@gmail.com/
> should have covered this.
>
> Suggest you reply this patch email and declare the dropping to avoid
> confusion.
>
> On 2024/11/13 10:02, Ragavendra wrote:
> > Initializing the val variable of type u32 as it was not initialized.
> >
> > Fixes: 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
> > Signed-off-by: Ragavendra Nagraj <ragavendra.bn@gmail.com>
> > ---
> > drivers/clk/sophgo/clk-cv18xx-pll.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/sophgo/clk-cv18xx-pll.c b/drivers/clk/sophgo/clk-cv18xx-pll.c
> > index 29e24098bf5f..04a0419cab4e 100644
> > --- a/drivers/clk/sophgo/clk-cv18xx-pll.c
> > +++ b/drivers/clk/sophgo/clk-cv18xx-pll.c
> > @@ -87,7 +87,7 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
> > static int ipll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
> > {
> > - u32 val;
> > + u32 val = 0;
> > struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
> > return ipll_find_rate(pll->pll_limit, req->best_parent_rate,
hi Chen,
You are correct, please drop this patch email.
--
Yours sincerely,
Ragavendra N
prev parent reply other threads:[~2024-11-14 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 2:02 [PATCH] clk:sophgo:clk-cv18xx-pll: fix unitialized u32 variable Ragavendra
2024-11-13 23:36 ` Chen Wang
2024-11-14 20:04 ` Ragavendra B.N. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzZXxxSghLGy_mZf@desktop \
--to=ragavendra.bn@gmail.com \
--cc=inochiama@outlook.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox