Of fsl_mc_allocator_driver_exit

Of fsl_mc_allocator_driver_exit

[Dr. David Alan Gilbert]

Hi,
  One of my scripts noticed that fsl_mc_allocator_driver_exit()
was added explicitly in
commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")

but appears to be unused; given it's a cleanup function it feels like
it should be wired up _somewhere_.

However, I know nothing of this driver, so it feels best to ask you.

Thanks in advance,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: Of fsl_mc_allocator_driver_exit

[Dr. David Alan Gilbert]

Note  Laurentiu's address bounses:

Final-Recipient: rfc822;laurentiu.tudor@nxp.com
Status: 5.0.0
Remote-MTA: dns; nxp-com.mail.protection.outlook.com
Diagnostic-Code: smtp; 550 5.4.1 Recipient address rejected: Access denied.
+[DU2PEPF00028D04.eurprd03.prod.outlook.com 2024-11-15T13:49:57.944Z 08DD047932C9EF2B]

* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> Hi,
>   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> was added explicitly in
> commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> 
> but appears to be unused; given it's a cleanup function it feels like
> it should be wired up _somewhere_.
> 
> However, I know nothing of this driver, so it feels best to ask you.
> 
> Thanks in advance,
> 
> Dave
> 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: Of fsl_mc_allocator_driver_exit

[Ioana Ciornei]

> * Dr. David Alan Gilbert (linux@treblig.org) wrote:
> > Hi,
> >   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> > was added explicitly in
> > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> >
> > but appears to be unused; given it's a cleanup function it feels like
> > it should be wired up _somewhere_.
> >

I don't think that fsl_mc_allocator_driver_exit() is of any use at this
point. The entire FSL_MC_BUS can only be built-in which means that there
is no module_exit() which references it.

The same thing is true about the dprc_driver_exit() function.

Ioana

Re: Of fsl_mc_allocator_driver_exit

[Dr. David Alan Gilbert]

* Ioana Ciornei (ioana.ciornei@nxp.com) wrote:
> > * Dr. David Alan Gilbert (linux@treblig.org) wrote:
> > > Hi,
> > >   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> > > was added explicitly in
> > > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> > >
> > > but appears to be unused; given it's a cleanup function it feels like
> > > it should be wired up _somewhere_.
> > >
> 
> I don't think that fsl_mc_allocator_driver_exit() is of any use at this
> point. The entire FSL_MC_BUS can only be built-in which means that there
> is no module_exit() which references it.

OK, well I'm happy to send a patch to clean it out, I was also
going to clean out fsl_mc_portal_reset().

> The same thing is true about the dprc_driver_exit() function.

Hmm, that's explicitly called from the error path of fsl_mc_bus_driver_init

Dave

> Ioana
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: Of fsl_mc_allocator_driver_exit

[Ioana Ciornei]

On Fri, Nov 15, 2024 at 02:26:19PM +0000, Dr. David Alan Gilbert wrote:
> * Ioana Ciornei (ioana.ciornei@nxp.com) wrote:
> > > * Dr. David Alan Gilbert (linux@treblig.org) wrote:
> > > > Hi,
> > > >   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> > > > was added explicitly in
> > > > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> > > >
> > > > but appears to be unused; given it's a cleanup function it feels like
> > > > it should be wired up _somewhere_.
> > > >
> >
> > I don't think that fsl_mc_allocator_driver_exit() is of any use at this
> > point. The entire FSL_MC_BUS can only be built-in which means that there
> > is no module_exit() which references it.
>
> OK, well I'm happy to send a patch to clean it out, I was also
> going to clean out fsl_mc_portal_reset().

Sure. Please keep me in cc so that I can give it a run.

>
> > The same thing is true about the dprc_driver_exit() function.
>
> Hmm, that's explicitly called from the error path of fsl_mc_bus_driver_init

My bad. I missed that.

Thanks,
Ioana

Re: Of fsl_mc_allocator_driver_exit

[Dr. David Alan Gilbert]

* Ioana Ciornei (ioana.ciornei@nxp.com) wrote:
> On Fri, Nov 15, 2024 at 02:26:19PM +0000, Dr. David Alan Gilbert wrote:
> > * Ioana Ciornei (ioana.ciornei@nxp.com) wrote:
> > > > * Dr. David Alan Gilbert (linux@treblig.org) wrote:
> > > > > Hi,
> > > > >   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> > > > > was added explicitly in
> > > > > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> > > > >
> > > > > but appears to be unused; given it's a cleanup function it feels like
> > > > > it should be wired up _somewhere_.
> > > > >
> > >
> > > I don't think that fsl_mc_allocator_driver_exit() is of any use at this
> > > point. The entire FSL_MC_BUS can only be built-in which means that there
> > > is no module_exit() which references it.
> >
> > OK, well I'm happy to send a patch to clean it out, I was also
> > going to clean out fsl_mc_portal_reset().
> 
> Sure. Please keep me in cc so that I can give it a run.

No problem.

> >
> > > The same thing is true about the dprc_driver_exit() function.
> >
> > Hmm, that's explicitly called from the error path of fsl_mc_bus_driver_init
> 
> My bad. I missed that.

OK,

Dave

> Thanks,
> Ioana
> 
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/