From: Niklas Cassel <cassel@kernel.org>
To: 412574090@163.com
Cc: dlemoal@kernel.org, James.Bottomley@hansenpartnership.com,
andreas@gaisler.com, andrew+netdev@lunn.ch, davem@davemloft.net,
deller@gmx.de, edumazet@google.com, linux-kernel@vger.kernel.org,
martin.petersen@oracle.co, mpe@ellerman.id.au, ojeda@kernel.org,
perex@perex.cz, sudipm.mukherjee@gmail.com,
t.sailer@alumni.ethz.ch, weiyufeng@kylinos.cn,
xiongxin@kylinos.cn
Subject: Re: [PATCH v2 1/4] parport: use standard kernel printing functions
Date: Mon, 18 Nov 2024 13:29:23 +0100 [thread overview]
Message-ID: <ZzszI9obKws73vgL@ryzen> (raw)
In-Reply-To: <20241118023024.22287-1-412574090@163.com>
Hello weiyufeng,
On Mon, Nov 18, 2024 at 10:30:24AM +0800, 412574090@163.com wrote:
> > On 11/12/24 11:11, 412574090@163.com wrote:
> > > From: weiyufeng <weiyufeng@kylinos.cn>
> > >
> > > change printk to standard kernel printing functions.
> > >
> > > Signed-off-by: weiyufeng <weiyufeng@kylinos.cn>
> > > ---
> > > drivers/net/hamradio/baycom_epp.c | 8 ++++----
> > > drivers/net/hamradio/baycom_par.c | 6 +++---
> > > drivers/parport/parport_pc.c | 12 ++++++------
> > > drivers/parport/procfs.c | 2 +-
> >
> > This is mixing changes for different drivers. Please split the net and ata part
> > into different patches and send the net ones to the correct list and maintainers.
> Yes, it will be updated in v3 version. Can you help review the patch for
> path2-patch4? If possible, it would be a great honor.
Sorry, that is not how it works.
If I look at patch 2/4, it changes all these files:
drivers/ata/pata_parport/bpck6.c | 2 +-
drivers/ata/pata_parport/pata_parport.c | 2 +-
drivers/auxdisplay/ks0108.c | 4 +--
drivers/net/hamradio/baycom_epp.c | 10 +++---
drivers/net/hamradio/baycom_par.c | 6 ++--
drivers/net/plip/plip.c | 2 +-
drivers/parport/daisy.c | 2 +-
drivers/parport/parport_gsc.c | 8 ++---
drivers/parport/parport_ip32.c | 8 ++---
drivers/parport/parport_mfc3.c | 2 +-
drivers/parport/parport_pc.c | 42 ++++++++++++-------------
drivers/parport/parport_sunbpp.c | 24 +++++++-------
drivers/parport/procfs.c | 2 +-
drivers/parport/share.c | 6 ++--
drivers/scsi/imm.c | 8 ++---
drivers/scsi/ppa.c | 10 +++---
include/linux/parport.h | 4 +--
include/linux/parport_pc.h | 18 +++++------
sound/drivers/mts64.c | 6 ++--
sound/drivers/portman2x4.c | 6 ++--
So we cannot give your Reviewed-by tag to this commit.
So please split the commit to the appropriate subsystems,
and CC: the proper mailing lists for each commit.
(Check the MAINTAINERS file.)
Then people will be able to review your changes.
Kind regards,
Niklas
next prev parent reply other threads:[~2024-11-18 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 2:11 [PATCH v2 0/4] add new iomem type for parport devcie 412574090
2024-11-12 2:11 ` [PATCH v2 1/4] parport: use standard kernel printing functions 412574090
2024-11-12 5:03 ` Damien Le Moal
2024-11-18 2:30 ` 412574090
2024-11-18 12:29 ` Niklas Cassel [this message]
2024-11-12 2:11 ` [PATCH v2 2/4] parport: change struct parport member to iobase 412574090
2024-11-12 2:11 ` [PATCH v2 3/4] parport: add parport_data struct 412574090
2024-11-12 2:11 ` [PATCH v2 4/4] parport: add iomem type for parport 412574090
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzszI9obKws73vgL@ryzen \
--to=cassel@kernel.org \
--cc=412574090@163.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andreas@gaisler.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.co \
--cc=mpe@ellerman.id.au \
--cc=ojeda@kernel.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
--cc=t.sailer@alumni.ethz.ch \
--cc=weiyufeng@kylinos.cn \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox