From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 868A81BD9D2 for ; Mon, 18 Nov 2024 16:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731949001; cv=none; b=B3ubxiqVT1xTKeepuV1sSZY+f5QnfgzicHIli6MeTaBuvubV0Torc2b2KhDOsXZjFfU0HPu9jxuNAIpbw02yuEarzaBKzFcQA6P1+afnshkA4TszPFNLI/1ywKhgbcMjiTVGhuHBFQJOdni/lGX5DVzo0g6T5vOnwRd5/WK5rkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731949001; c=relaxed/simple; bh=m4HVZ3+6RXsvVWE65C+L+Ujbbo6+dMR0YMemergLGyk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iRygUMqh7U8elg7rUaua+KApyv4BHNnTvC6b+inLtYs2FtH/LxGBtXCN5ck6JJxAsYDytaXnRJdUgt2gJR6LaeOxKIzBBlUUn9kb1jqKQikgqgewMusYyDvQZIhgQ8k1jhMOecSJu7kUhJnK4x6i/iBzAsL9vf6ZApoPmICYrOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XAa5sqiS; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XAa5sqiS" Date: Mon, 18 Nov 2024 16:56:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731948996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=59zS/1A05nM4M6tWzQtKALV91pOAZt9Z4V177dGFIA4=; b=XAa5sqiSA09ONIFQdTjTyerzgYSOFcQHoT32a0p2NLv3tpiBjMSfZwJ6W6St+SW7dMXSOV wzDOpyS2hU71eVWoIhWLa1gA6nvq+lvfxxBdOzicUd8TBCTb0n1IJ3af6Qv8Bl8jSqRK/c NcjQ+xtGFxNUs/8M0AwzOm5jwQF8Tkc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Keren Sun Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: remove the non-useful else after a break in a if statement Message-ID: References: <20241115235744.1419580-1-kerensun@google.com> <20241115235744.1419580-4-kerensun@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241115235744.1419580-4-kerensun@google.com> X-Migadu-Flow: FLOW_OUT On Fri, Nov 15, 2024 at 03:57:44PM -0800, Keren Sun wrote: > Remove the else block since there is already a break in the statement of > if (iter->oom_lock), just set iter->oom_lock true after the if block > ends. > > Signed-off-by: Keren Sun Reviewed-by: Roman Gushchin Thanks!