From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 14/15] usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly
Date: Tue, 19 Nov 2024 17:53:55 +0200 [thread overview]
Message-ID: <Zzy0kz54bW3Xe0Al@kuha.fi.intel.com> (raw)
In-Reply-To: <20241118072917.3853-15-wsa+renesas@sang-engineering.com>
On Mon, Nov 18, 2024 at 08:29:13AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 9cda1005ef01..bc5fd2557e6f 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -11,7 +11,6 @@
> #include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/pm_wakeup.h>
> #include <linux/pm_wakeirq.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> --
> 2.39.2
--
heikki
next prev parent reply other threads:[~2024-11-19 15:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 7:28 [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly Wolfram Sang
2024-11-18 7:29 ` [PATCH 01/15] x86/platform/olpc-xo1-sci: " Wolfram Sang
2024-11-18 7:29 ` [PATCH 02/15] drivers core: " Wolfram Sang
2024-12-05 11:17 ` Rafael J. Wysocki
2024-11-18 7:29 ` [PATCH 03/15] HID: google: " Wolfram Sang
2024-11-18 9:58 ` Jiri Kosina
2024-11-18 7:29 ` [PATCH 04/15] coresight: etm4x: " Wolfram Sang
2024-11-18 10:34 ` Suzuki K Poulose
2024-11-18 19:34 ` Wolfram Sang
2024-11-18 7:29 ` [PATCH 05/15] Input: spear-keyboard - " Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys " Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
2024-11-18 7:29 ` [PATCH 07/15] media: mceusb: " Wolfram Sang
2024-11-18 7:29 ` [PATCH 08/15] mmc: core: " Wolfram Sang
2024-12-02 15:23 ` Ulf Hansson
2024-11-18 7:29 ` [PATCH 09/15] net: phy: broadcom: " Wolfram Sang
2024-11-18 20:13 ` Florian Fainelli
2024-11-18 7:29 ` [PATCH 10/15] net: wwan: t7xx: " Wolfram Sang
2024-11-18 19:52 ` Sergey Ryazanov
2024-11-18 7:29 ` [PATCH 11/15] PCI: " Wolfram Sang
2024-11-20 22:34 ` Bjorn Helgaas
2024-12-22 21:22 ` Krzysztof Wilczyński
2024-11-18 7:29 ` [PATCH 12/15] platform/x86: quickstart: " Wolfram Sang
2024-12-02 17:17 ` Ilpo Järvinen
2024-11-18 7:29 ` [PATCH 13/15] rtc: brcmstb-waketimer: " Wolfram Sang
2024-11-18 13:48 ` (subset) " Alexandre Belloni
2024-11-18 7:29 ` [PATCH 14/15] usb: typec: tcpci_mt6370: " Wolfram Sang
2024-11-19 15:53 ` Heikki Krogerus [this message]
2024-11-18 7:29 ` [PATCH 15/15] PM / Sleep: " Wolfram Sang
2024-12-05 11:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zzy0kz54bW3Xe0Al@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox