From: Christoph Hellwig <hch@infradead.org>
To: Alexey Romanov <avromanov@salutedevices.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk,
terrelln@fb.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, kernel@salutedevices.com
Subject: Re: [PATCH v1 3/3] zram: introduce crypto-api backend
Date: Tue, 19 Nov 2024 04:34:52 -0800 [thread overview]
Message-ID: <ZzyF7PAoII0E5Vf5@infradead.org> (raw)
In-Reply-To: <20241119122713.3294173-4-avromanov@salutedevices.com>
On Tue, Nov 19, 2024 at 03:27:13PM +0300, Alexey Romanov wrote:
> Since we use custom backend implementation, we remove the ability
> for users to use algorithms from crypto backend. This breaks
> backward compatibility, user doesn't necessarily use one of the
> algorithms from "custom" backends defined in zram folder.
> For example, he can use some driver with hardware compression support.
>
> This patch adds opinion to enable Crypto API: add ZRAM_BACKEND_CRYPTO_API.
> Option is enabled by default, because in previously version of ZRAM
> it was possible to choose any alogirthm using Crypto API. This is
> also done for backward compatibility purposes.
Which crypto API algorithm do you care about? You should probably
just add a backend for that instead of a double indirection.
next prev parent reply other threads:[~2024-11-19 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 12:27 [PATCH v1 0/3] zram: introduce crypto-backend api Alexey Romanov
2024-11-19 12:27 ` [PATCH v1 1/3] zram: pass zcomp instead of zcomp_params to create_context method Alexey Romanov
2024-11-19 12:27 ` [PATCH v1 2/3] zram: store crypto backends in list instead of array Alexey Romanov
2024-11-19 12:27 ` [PATCH v1 3/3] zram: introduce crypto-api backend Alexey Romanov
2024-11-19 12:34 ` Christoph Hellwig [this message]
2024-11-19 13:04 ` Alexey Romanov
2024-11-19 13:08 ` Christoph Hellwig
2024-11-22 14:59 ` kernel test robot
2024-11-20 3:15 ` [PATCH v1 0/3] zram: introduce crypto-backend api Sergey Senozhatsky
2024-11-21 12:11 ` Alexey Romanov
2024-11-21 15:53 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzyF7PAoII0E5Vf5@infradead.org \
--to=hch@infradead.org \
--cc=avromanov@salutedevices.com \
--cc=axboe@kernel.dk \
--cc=kernel@salutedevices.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox