[PATCH 1/1] perf tests hwmon_pmu: Remove double evlist__delete()

[PATCH 1/1] perf tests hwmon_pmu: Remove double evlist__delete()

[Arnaldo Carvalho de Melo]

In the error path when failing to parse events the evlist is being
deleted twice, keep the one after the out label.

Fixes: 531ee0fd4836994f ("perf test: Add hwmon "PMU" test")
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/hwmon_pmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c
index 1e5f93aaaf5f9210..d8ed00d45dd7249e 100644
--- a/tools/perf/tests/hwmon_pmu.c
+++ b/tools/perf/tests/hwmon_pmu.c
@@ -155,8 +155,6 @@ static int do_test(size_t i, bool with_pmu, bool with_alias)
 	parse_events_error__init(&err);
 	ret = parse_events(evlist, str, &err);
 	if (ret) {
-		evlist__delete(evlist);
-
 		pr_debug("FAILED %s:%d failed to parse event '%s', err %d\n",
 			 __FILE__, __LINE__, str, ret);
 		parse_events_error__print(&err, str);
-- 
2.47.0


----- End forwarded message -----

Re: [PATCH 1/1] perf tests hwmon_pmu: Remove double evlist__delete()

[Namhyung Kim]

On Tue, 19 Nov 2024 16:34:31 -0300, Arnaldo Carvalho de Melo wrote:

> In the error path when failing to parse events the evlist is being
> deleted twice, keep the one after the out label.
> 
> 

Applied to perf-tools-next, thanks!

Best regards,
Namhyung