Re: [Bug #14015] pty regressed again, breaking expect and gcc's testsuite

Mikael Pettersson
2009-09-05T10:46:41Z

Linus Torvalds writes:
>
>
> On Fri, 4 Sep 2009, Linus Torvalds wrote:
> >
> > I'm sure you already figured the obvious meaning out, but here's a fixed
> > version.
>
> And here's another patch that may also fix this, simply by virtue of
> writing the "\r\n" as a single string, rather than as two characters. That
> way, we should never get into the situation that th '\r' allocates a new
> buffer (larger than one character), and then the later '\n' writing
> decides that we've filled up.

Thanks, I'm testing this and the pty_write() fix on i686 and ppc64 now.

Sometimes the bug is difficult to trigger, so I may need to do loads of
testing with different gcc versions before I dare to say that it's fixed.

/Mikael