From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762A1C46CA1 for ; Fri, 13 Oct 2023 13:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbjJMNM3 (ORCPT ); Fri, 13 Oct 2023 09:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbjJMNM1 (ORCPT ); Fri, 13 Oct 2023 09:12:27 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2068.outbound.protection.outlook.com [40.107.220.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0411C0; Fri, 13 Oct 2023 06:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSTC/qMflVc7+hISNm0rp2/evuVj5EMTYSXHQjywIkq9JhBH+lpJfKrkcn3pUl331lurisxPJYrr6dD8anfRST5qa+CN6iGic+kxiCHsvesAqALAGOZ5usxBILoB68FOMmFA7p7d6u8DNc+aG+qivgx4WlyDA/ZK4oOQBwHKXLxI4b0II+N9QBDs9nYf1gjdQt9F/6kGs5x6FyEKo2EggZHcfBdVwjWtTl19EEaBZUpqVPgHOjCvctZ6aDSuSTIADmX0IVzXYyzAzUnaWI648ndupdB7Im5Qn9y9/mr184OUCvsSZTOYKruX3QUKSxn8V7f4/fyTAhvFfFUAorkV8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/jw/TrC+2Ranv6Qum6RRoKm3C9oo9vf5WOifrjT9LCA=; b=CealTR/YzzGjBJ88zFz93dxlVY1yxunvTEokZUd/Q1JlPLc9MDpV1hRBGfU5BHAiHKvENmHJwpN0XfuuznxZ9lT8d2Ef1i1zg8eaoR5jOz5n1CWrhiL+TGCbeLx0LyoW2Oa8r8ZqiE9riHezxVdTxhuzdfEq5iUVVAO+lhSwABCkVvK0i2ue174OQzkvmcxhrFx70+tMVMXogrQfjT3k2TbTdbB8FrwPp/qRE2q5yyDl1RS2zxOCmIFPKCKJLyspwLpbH32wqHFTuj2XudWhhexMoRt8qdE3Ot0AH70qM/dK+OY2q6nRo9UirDnqF5AUXcLdIjKQdRK6/L3OdQa6Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/jw/TrC+2Ranv6Qum6RRoKm3C9oo9vf5WOifrjT9LCA=; b=ruQ/j2xErjArTRCEqjTmjue5f8HIaix2nnTlmvo8o6bI2GqPIGPVXYQw5yA06pNFrP+vTeOjsrND7DkVtqCdEI8u/TFFVwVup94PjnhAD6iOU7WBUqiAdMl3tdz3oVByYLFuq7Gn11MeR5/ltY29CEveNd9HoBDwxredwYi6A4Q= Received: from DM6PR13CA0009.namprd13.prod.outlook.com (2603:10b6:5:bc::22) by PH7PR12MB6444.namprd12.prod.outlook.com (2603:10b6:510:1f8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.43; Fri, 13 Oct 2023 13:12:22 +0000 Received: from CY4PEPF0000FCC2.namprd03.prod.outlook.com (2603:10b6:5:bc:cafe::5a) by DM6PR13CA0009.outlook.office365.com (2603:10b6:5:bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.16 via Frontend Transport; Fri, 13 Oct 2023 13:12:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCC2.mail.protection.outlook.com (10.167.242.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6838.22 via Frontend Transport; Fri, 13 Oct 2023 13:12:22 +0000 Received: from [192.168.137.2] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 13 Oct 2023 08:12:19 -0500 Message-ID: Date: Fri, 13 Oct 2023 15:12:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] dt-bindings: nvmem: Convert xlnx,zynqmp-nvmem.txt to yaml Content-Language: en-US To: Krzysztof Kozlowski , "Praveen Teja Kundanala" , , , , , , CC: References: <20231013101450.573-1-praveen.teja.kundanala@amd.com> <20231013101450.573-3-praveen.teja.kundanala@amd.com> <02d3fa42-75a3-4f4f-ade6-204c8146d694@linaro.org> <91d61e1a-abb0-4b31-aa22-aff72d582ebe@amd.com> <013e44c6-45f5-44c1-94b3-536955fae78f@amd.com> <5a3b6efe-5884-4727-a1e1-e9b8b0658523@amd.com> <209334cd-c922-4bd6-b116-83297c7e8b79@linaro.org> From: Michal Simek Autocrypt: addr=michal.simek@amd.com; keydata= xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+ FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/ If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/ y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3 3i3l5DA= In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC2:EE_|PH7PR12MB6444:EE_ X-MS-Office365-Filtering-Correlation-Id: 06c01c70-a8a6-43c9-5f73-08dbcbee0996 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EePs+iVn+2741dVKWkmk7Zwp2UodtlgfKbghZ+sxLZGNd3U8P0/U7itICZS+bf8YZJzGpqCX3VSzzMfZDqZwMYlpYC33WAh2mWrEDeFeKB0uab6OGAZobtgQmS6OJoLIXS2xCTVUcsNmnwn4AWBvPxRWERh2gQPE4ylxGlQxILn18OkBzSGNb7u9LTaYqscUyqiRpKkSjJSgVk6zfBT1hh4LP+bMYv3ZRJyC/PqGg9j+J8fw/72E3OxtUgLfUNt5dIw4LE5oXbApXT/o+IYSf/e7FZhtCWwvr+Lh+Tjytnbywj53KdIM6jyqeKuUF/5eRVKtpMDFume1yrS3RxxGvqU8Pxn4gzKsno/aFT9yW6hKQfrlyD70uAYfh17NklD/aQVcetz9h7D5W8dWnhG8JT7XBrEzzMIZ/JEn8NkLENfLm93ygjGXpWHP8Pi7C+NIUfF/6sAGnbjEFdyiTYaR2mMQ1bk7P9srSW2pAP9hV+HST6ltcJiG8jEuB07fx+McFDWDjG9Zq3Y0vXobCsjWRG8Q+nU38sE0mUDrhNI5UHjE6qJuE3TtmvAEuPi1oXdEoDDV9oZPuXmnN5qBfpD4cgzgbo4F9v3XZGgsGcb9IGfRivwOQeJx5iaMGV8qaYiAadvT2SD1s2MHaj3eWbMndYeU6N4vlrA7HERhz+w4cCS6lvZgJFxAza03aV/B/tCpdEhhXzCL6tF2b+1egYps2lYIt+Y3Rd3HTcDlQt/eS7JRSEqkjdy5suluOzTxIQMYPSrvq0tq7ZVjnQo+hHOy7KvgsXBwRlJmXG/IEBC+d/E= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(396003)(376002)(346002)(39860400002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(82310400011)(46966006)(40470700004)(36840700001)(316002)(70586007)(70206006)(31686004)(16576012)(4326008)(8936002)(8676002)(41300700001)(36756003)(336012)(426003)(110136005)(81166007)(36860700001)(356005)(5660300002)(82740400003)(44832011)(2906002)(966005)(16526019)(47076005)(26005)(2616005)(478600001)(40460700003)(31696002)(53546011)(86362001)(40480700001)(83380400001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 13:12:22.5468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06c01c70-a8a6-43c9-5f73-08dbcbee0996 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6444 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/23 15:10, Krzysztof Kozlowski wrote: > On 13/10/2023 15:06, Michal Simek wrote: >> >> >> On 10/13/23 14:54, Krzysztof Kozlowski wrote: >>> On 13/10/2023 14:08, Michal Simek wrote: >>>> >>>> >>>> On 10/13/23 13:58, Krzysztof Kozlowski wrote: >>>>> On 13/10/2023 13:51, Michal Simek wrote: >>>>>> >>>>>> >>>>>> On 10/13/23 13:46, Krzysztof Kozlowski wrote: >>>>>>> On 13/10/2023 13:22, Michal Simek wrote: >>>>>>>>> >>>>>>>>>> + >>>>>>>>>> +required: >>>>>>>>>> + - compatible >>>>>>>>> >>>>>>>>> required: block goes after patternProperties: block >>>>>>>>> >>>>>>>>>> + >>>>>>>>>> +patternProperties: >>>>>>>>>> + "^soc_revision@0$": >>>>>>>>> >>>>>>>>> Why do you define individual memory cells? Is this part of a binding? >>>>>>>>> IOW, OS/Linux requires this? >>>>>>>> >>>>>>>> nvmem has in kernel interface where you can reference to nodes. nvmem_cell_get() >>>>>>>> calls. It means you should be able to describe internal layout that's why names >>>>>>>> are used. And address in name is there because of reg property is used to >>>>>>>> describe base offset and size. >>>>>>> >>>>>>> That's not really what I am asking. Why internal layout of memory must >>>>>>> be part of the bindings? >>>>>> >>>>>> It doesn't need to be but offsets are hardcoded inside the driver itself and >>>>>> they can't be different. >>>>> >>>>> Hm, where? I opened drivers/nvmem/zynqmp_nvmem.c and I do not see any >>>>> hard-coded offsets. >>>> >>>> Current driver supports only soc revision from offset 0. >>>> But if you look at 5/5 you need to define offsets where information is present. >>>> +#define SOC_VERSION_OFFSET 0x0 >>>> +#define EFUSE_START_OFFSET 0xC >>>> +#define EFUSE_END_OFFSET 0xFC >>>> +#define EFUSE_PUF_START_OFFSET 0x100 >>>> +#define EFUSE_PUF_MID_OFFSET 0x140 >>>> +#define EFUSE_PUF_END_OFFSET 0x17F >>> >>> There is nothing like this in existing driver, so the argument that "I >>> am adding this to the binding during conversion because driver needs it" >>> is not true. Conversion is only a conversion. >> >> Conversion in 2/5 is adding only soc revision which is already there. It is >> starting from 0 and world size is 1. And 0 is not listed because that's start >> all the time. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nvmem/zynqmp_nvmem.c?h=v6.6-rc5#n39 > > This defines the nvmem config, not what should be where. If you have only one entry you are also saying where it is. Thanks, Michal