[PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[herculoxz]

From: Abhinav Ananthu <abhinav.ogl@gmail.com>

 Update auxiliary FFI callback signatures to reference the `c_` types
 provided by the kernel prelude, rather than accessing them via
 `kernel::ffi::`.

Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
---
 rust/kernel/auxiliary.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
index d2cfe1eeefb6..030e31333689 100644
--- a/rust/kernel/auxiliary.rs
+++ b/rust/kernel/auxiliary.rs
@@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
     extern "C" fn probe_callback(
         adev: *mut bindings::auxiliary_device,
         id: *const bindings::auxiliary_device_id,
-    ) -> kernel::ffi::c_int {
+    ) -> c_int {
         // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
         // `struct auxiliary_device`.
         //
-- 
2.34.1

Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[Greg KH]

On Tue, Aug 12, 2025 at 09:24:21AM +0530, herculoxz wrote:
> From: Abhinav Ananthu <abhinav.ogl@gmail.com>
> 
>  Update auxiliary FFI callback signatures to reference the `c_` types
>  provided by the kernel prelude, rather than accessing them via
>  `kernel::ffi::`.

Why is this indented?

Also, note that your "From:" line in your email client doesn't reflect
your name here.  That might be fine, but it's a bit odd and triggers my
checks.

thanks,

greg k-h

[PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[Abhinav Ananthu]

Update auxiliary FFI callback signatures to reference the `c_` types
provided by the kernel prelude, rather than accessing them via
`kernel::ffi::`.

Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
---
 rust/kernel/auxiliary.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
index d2cfe1eeefb6..030e31333689 100644
--- a/rust/kernel/auxiliary.rs
+++ b/rust/kernel/auxiliary.rs
@@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
     extern "C" fn probe_callback(
         adev: *mut bindings::auxiliary_device,
         id: *const bindings::auxiliary_device_id,
-    ) -> kernel::ffi::c_int {
+    ) -> c_int {
         // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
         // `struct auxiliary_device`.
         //
-- 
2.34.1

Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[Greg KH]

On Tue, Aug 12, 2025 at 01:21:10PM +0530, Abhinav Ananthu wrote:
> Update auxiliary FFI callback signatures to reference the `c_` types
> provided by the kernel prelude, rather than accessing them via
> `kernel::ffi::`.
> 
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
> ---
>  rust/kernel/auxiliary.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
> index d2cfe1eeefb6..030e31333689 100644
> --- a/rust/kernel/auxiliary.rs
> +++ b/rust/kernel/auxiliary.rs
> @@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
>      extern "C" fn probe_callback(
>          adev: *mut bindings::auxiliary_device,
>          id: *const bindings::auxiliary_device_id,
> -    ) -> kernel::ffi::c_int {
> +    ) -> c_int {
>          // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
>          // `struct auxiliary_device`.
>          //
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[Danilo Krummrich]

On Tue Aug 12, 2025 at 9:51 AM CEST, Abhinav Ananthu wrote:
> Update auxiliary FFI callback signatures to reference the `c_` types
> provided by the kernel prelude, rather than accessing them via
> `kernel::ffi::`.
>
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>

This looks good now, I'll later on pick this one up.

One additional note, when sending updates on previous patches, please make sure
to increase the version number of the patch, see also [1].

Also, please add a note about what changes you made between versions below the
'---' line of the commit.

- Danilo

[1] https://docs.kernel.org/process/submitting-patches.html#subject-line

Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of

[Danilo Krummrich]

On 8/12/25 9:51 AM, Abhinav Ananthu wrote:
> Update auxiliary FFI callback signatures to reference the `c_` types
> provided by the kernel prelude, rather than accessing them via
> `kernel::ffi::`.
> 
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>

Applied to driver-core-testing, thanks!