From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F4827F736 for ; Fri, 6 Feb 2026 02:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770345731; cv=none; b=EAeQjJ4eSdIX3FC66zohy4EcZvgXEDIxkII5T8FeEPkHRqsBaiiMQH0bRxzV48056KuacaR3YeBTkq1dtTgOIGeQsFJ80wJ2wGiSi3H/fpP3j/4Gqh4kZ34xg6UAwSM+EWkjeeOOvFy14C0pIfJpDhK9P1JheIFa6Uc/AJp4HCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770345731; c=relaxed/simple; bh=ksr2lcOAzAjEvzHUJmQgSRlgYT57MjEzGRV/tMTgUXA=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=GTNpsQVEc9Lf6DkOR+1803G6hJxw9xf4sNq1PiLwjGG8txVQoqSNj6LSPAnUw4hjDUQ+tsmJKvTbjBw0aHFJLQxb0iU/fwAzmyMhWhUnRuNRb3vcdcJRjif0aBlcJ4Qry2KIOgAD4APYW6bwjRPILNZq+BZu+fr5bpgxW4FSsDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LzDJUKAu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MZkoNjC1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LzDJUKAu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MZkoNjC1" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6160xhCj1301511 for ; Fri, 6 Feb 2026 02:42:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yf5z0lQJncwdyjILWejtIHYcqO4ZW+jUcKeWyUcI4YI=; b=LzDJUKAuLoCLzj0y AGAUylLRFMM8n7uUGhErnk+P3JU+YMwoQDWwPolBUwSu2DEIYCVceQ5KXJL/3b+9 /lb9K2eWkpVTOFwQaFToiXx05V/+I1i5vzF7CwJt1PwXV1wfHi5AHyxf5maSoDeW aljVhPkJbMMie+48H4Y6Jgc+poNcEs3NtgzmJhm1ql1LpIXv0MtUPzRBkJOk4Lhg 1w3I3lJsulOYuDOA4PY7NWZbLmZAiUYnrtmXRKx9GaznRyIVxg28GVp+xMgS7He+ ZZ62vWQE+WW/0fLjceex+t0ZBxRnHw0LEV1hrNtuJaY7MrXqEgOCl6M1ur9BhwkZ Npl3OA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c4vxht6dw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 02:42:10 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a8c273332cso6090945ad.1 for ; Thu, 05 Feb 2026 18:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770345729; x=1770950529; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yf5z0lQJncwdyjILWejtIHYcqO4ZW+jUcKeWyUcI4YI=; b=MZkoNjC1V3OmQTytS8LlgjR2sHS9g2vuyRNuzTouwd4MiruZdXAQbIEpV9gqxA55np r1aWhmqbBGa8IYNLjFDF2vJBDu6r3YHGkzdJB/yV9Hx77U4MlQB1Rh0FI4KCNn8H+7Ru wNRmYNH6t8yVMnj1LcyWqi8qZotuNsWPYFPRQiPPi2S5ZrmF5v1P0HjvEM0e3nEyDvGW GIArKj6OZwjd7hobWkebpoevcJjCm/PBbNH4QuMl157eq/y9oRSdtGrRg2apSuHIUoVZ ODjLddxDiF36GmEXphxA+F+nLloYvBJ3OuEvja1gAqILIXN12sTDcy6Sab42DKMDNcnr fLiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770345729; x=1770950529; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yf5z0lQJncwdyjILWejtIHYcqO4ZW+jUcKeWyUcI4YI=; b=icNNOY7kvOtk+/rgW+mFyzmjh3A2wRcxmfyzH7YnTO0cE83rsjYeW7xPF2efGLnAYK QtkRnniMTOY5CPJlZC3RU/HzvYTopsLW9wiRLvpTs7EKA3q/Nl3yJXo8o0/gh4inEOIq RpDwNVLRmY8KLEDc1Jn8++jHm5zWJejTkuE7xokEYuhclzuKeEDon7jxWHDcyB8aYSJx Suw24nqzkd42Q8rPlhU6Ib0HzMEsMIwMd7Brc3zmn4tspgSWGiz3JXy1YXw3FbXnRPAB tFgU9iFYbq5DgQr+vyG1JtoS2taMouHoK1438+fub/CCT2R0zNicCuA/B9NNglHtz+Kf pSfA== X-Forwarded-Encrypted: i=1; AJvYcCV0IjeXrGVHKwWMunsmchDLXN9kiL7N1r3g6vRv4797QRRtjyORQpYksj2xNvUGBiTYqF2JVMM1DElpyX8=@vger.kernel.org X-Gm-Message-State: AOJu0YxKHIlq0ZDTmZn1UTHFxyge3fcpTHyW8X9it2DnShVULJCm2zDz U7Qzcr33egFAVtxNI+O7Lpt5tj66o8uXxS+cWp49eA29oT1ukA0z7RMerpNXTvcMcEiIOuVkOlH J6aISIJGi/7nPIWABzVatgyrKKS3h/+Yh7vyD0jVfQ9WKRodS3f0Yv25N4lgzv+MN9XI= X-Gm-Gg: AZuq6aJuRfoNY74UZpKlhqnt/IOn4B53QVXZOa0LcNpF4xVYgm0swlcSdLx3Zr5mFA2 iHXMdKV+uIksTTAivA5XRKuOvNyzXiRnzUX6dk3Zk33kBDlnR4aEnPgXer6klnWng1ADHYB9gsz WxkKETU2TINtkV2VKtFuKcG0aAKw70pmSj2/lg8OdjDLQ5dUzdkvM/gkfuiI6CxxlzrQRdGX18v Yq2wLFSCTSwCuEVP5lTbj9fBuu/3gbhmwRB7ZSxcliFCroUkI6rjKjzIwMof8PjYq5RxLUwpj+f wJZFlUbzNBi64LunMJreoDpmdFWmQmRnhQWb1GiL2j3UQS9MKkbbWW4uQMGrfDjEOhldB/BkCYi mlPsp05FM7OdiOhw8K6fm8ANDq9pd456TnLAcfRxRblDz111KijrfiiIh3crsW5ucP7/MvJ102U 7Afu22 X-Received: by 2002:a17:902:cccf:b0:2a0:acf6:3de9 with SMTP id d9443c01a7336-2a9519ba4c2mr13991145ad.58.1770345729138; Thu, 05 Feb 2026 18:42:09 -0800 (PST) X-Received: by 2002:a17:902:cccf:b0:2a0:acf6:3de9 with SMTP id d9443c01a7336-2a9519ba4c2mr13990955ad.58.1770345728649; Thu, 05 Feb 2026 18:42:08 -0800 (PST) Received: from [10.249.28.233] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a951c8b041sm7532115ad.34.2026.02.05.18.42.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 18:42:08 -0800 (PST) Message-ID: Date: Fri, 6 Feb 2026 10:42:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/6] media: qcom: iris: Add hierarchical coding support for encoder To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab References: <20260129-batch2_iris_encoder_enhancements-v4-0-efaac131a5f7@oss.qualcomm.com> <20260129-batch2_iris_encoder_enhancements-v4-4-efaac131a5f7@oss.qualcomm.com> <22af9d61-fdbe-4347-a1b0-1f8696a77f38@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: <22af9d61-fdbe-4347-a1b0-1f8696a77f38@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=GLoF0+NK c=1 sm=1 tr=0 ts=69855502 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=86qbpROpL-4TFvkmW_wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: 4qdTdb0hSYd8wOYsK5Gw5YIsA-crNhRv X-Proofpoint-ORIG-GUID: 4qdTdb0hSYd8wOYsK5Gw5YIsA-crNhRv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDAxNyBTYWx0ZWRfXxN5XJMV5neMc SNBqzxg/sjdfwengvR3LTKHiYa27w4k0Y8rEpb89zUw4e4d4SVl7EJQTa69MoqzfWia/1pDdtwx Woa8wwppPaTqakj5PKWpToXtqq5+PrUBV+qmFXDctJ7caPF2rJJ0f+lDqG2ttUc9xvrtWtOEgyD Tm4t4nf4xSmKJdNUy49RHs3EFh/kO4fEFe4kP+rr1hteb2gMgGy4eetLCgVl5+0Kkq0kbJrcRkZ oloa/0W6pHui5jXD0hQBgMNxr8frbW8UFuibvOzZPiWNxMT/u4sSfHclJ7pP+SvJu5vjfLNh6Mr +LnG48eAmEQiwpVy8WLM+28mK30/bmI2mtW+mMEK94V8arDtGARpfTjZBxhC+pRf2LUG3OgHsut HpXJ/ix7CIxThmsGsnm+eJZJPF/1rulmOTk/4GvjIV8UPNhL5vrAAGtfG9u2m5xrVtHipwEL0UW aGXqqCv4etsXCNT1ZzQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_01,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060017 On 2026/1/29 19:37, Vikash Garodia wrote: >> + >> +    if (inst->codec == V4L2_PIX_FMT_HEVC) >> +        max_bitrate = CABAC_MAX_BITRATE; >> + >> +    if (entropy_mode == V4L2_MPEG_VIDEO_H264_ENTROPY_MODE_CABAC) >> +        max_bitrate = CABAC_MAX_BITRATE; >> +    else >> +        max_bitrate = CAVLC_MAX_BITRATE; > > check this logic, for hevc, its reassiging > This is a bug and will be fixed in v5. >> +int iris_set_layer_count_gen1(struct iris_inst *inst, enum >> platform_inst_fw_cap_type cap_id) >> +{ >> +    const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; >> +    struct vb2_queue *sq = v4l2_m2m_get_src_vq(inst->m2m_ctx); >> +    struct vb2_queue *dq = v4l2_m2m_get_dst_vq(inst->m2m_ctx); >> +    u32 layer_enable = inst->fw_caps[LAYER_ENABLE].value; >> +    u32 layer_count = inst->fw_caps[cap_id].value; >> +    u32 hfi_id, ret; >> + >> +    if (!layer_enable || !layer_count) >> +        return -EINVAL; >> + >> +    inst->hfi_layer_count = layer_count; > > does it include base layer as well ? It does for gen2, so keep the > uniformity. > This API is designed for Gen1. The description below is taken from the HFI definition. The parameter ( N enh layers ) conveyed through this property specifies the number of enhancement layers to be encoded. N: base layer + N enhancement layers Layer ids: 0 for base layer, 1 for 1st enh layer and so on. >> +    { >> +        .cap_id = LAYER_TYPE_H264, >> +        .min = V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_B, >> +        .max = V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_P, >> +        .step_or_mask = >> BIT(V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_B) | >> +                BIT(V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_P), >> +        .value = V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_P, >> +        .hfi_id = HFI_PROP_LAYER_ENCODING_TYPE, >> +        .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU, > > no setter for h264 ? > will be added in v5. >> +    { >> +        .cap_id = LAYER5_BITRATE_HEVC, >> +        .min = 1, >> +        .max = BITRATE_MAX, >> +        .step_or_mask = 1, >> +        .value = BITRATE_DEFAULT, >> +        .hfi_id = HFI_PROP_BITRATE_LAYER5, > > HFI_PROP_BITRATE_LAYER6 ? > This is a bug and will be fixed in v5. -- Best Regards, Wangao