From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Vincent Shih <vincent.sunplus@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused
Date: Fri, 29 Apr 2022 10:29:48 +0100 [thread overview]
Message-ID: <a04e9d8e-33e4-a8a3-e4be-e4c098fe4b07@linaro.org> (raw)
In-Reply-To: <20220321110326.44652-1-krzk@kernel.org>
On 21/03/2022 11:03, Krzysztof Kozlowski wrote:
> "bcm_otpc_acpi_ids" is used with ACPI_PTR, so a build with !CONFIG_ACPI
> has a warning:
>
> drivers/nvmem/bcm-ocotp.c:247:36: error:
> ‘bcm_otpc_acpi_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied all thanks,
--srini
> ---
> drivers/nvmem/bcm-ocotp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c
> index a8097511582a..dfea96c52463 100644
> --- a/drivers/nvmem/bcm-ocotp.c
> +++ b/drivers/nvmem/bcm-ocotp.c
> @@ -244,7 +244,7 @@ static const struct of_device_id bcm_otpc_dt_ids[] = {
> };
> MODULE_DEVICE_TABLE(of, bcm_otpc_dt_ids);
>
> -static const struct acpi_device_id bcm_otpc_acpi_ids[] = {
> +static const struct acpi_device_id bcm_otpc_acpi_ids[] __maybe_unused = {
> { .id = "BRCM0700", .driver_data = (kernel_ulong_t)&otp_map },
> { .id = "BRCM0701", .driver_data = (kernel_ulong_t)&otp_map_v2 },
> { /* sentinel */ }
prev parent reply other threads:[~2022-04-29 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 11:03 [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 2/3] nvmem: sunplus-ocotp: staticize sp_otp_v0 Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 3/3] nvmem: sunplus-ocotp: drop useless probe confirmation Krzysztof Kozlowski
2022-04-29 9:29 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a04e9d8e-33e4-a8a3-e4be-e4c098fe4b07@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.sunplus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox