From: Dave Jiang <dave.jiang@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Vinod Koul <vkoul@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the dmaengine tree with Linus' tree
Date: Wed, 18 May 2022 15:43:08 -0700 [thread overview]
Message-ID: <a05caaa9-244b-a84f-88b2-2d6bfec61fdd@intel.com> (raw)
In-Reply-To: <20220519084049.3e5b58a8@canb.auug.org.au>
On 5/18/2022 3:40 PM, Stephen Rothwell wrote:
> Hi Dave,
>
> On Wed, 18 May 2022 10:20:59 -0700 Dave Jiang <dave.jiang@intel.com> wrote:
>> The lock needs to go around both functions, we can move it outside the if().
>>
>> + mutex_lock(&wq->wq_lock);
>> if (wq->state == IDXD_WQ_ENABLED) {
>> idxd_wq_disable_cleanup(wq);
>> - idxd_wq_device_reset_cleanup(wq);
>> wq->state = IDXD_WQ_DISABLED;
>> }
>> + idxd_wq_device_reset_cleanup(wq);
>> + mutex_unlock(&wq->wq_lock);
> Thanks for checking. I have made that change to my merge resolution.
Thank you!
next prev parent reply other threads:[~2022-05-18 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 5:34 linux-next: manual merge of the dmaengine tree with Linus' tree Stephen Rothwell
2022-05-18 11:46 ` Vinod Koul
2022-05-18 17:20 ` Dave Jiang
2022-05-18 22:40 ` Stephen Rothwell
2022-05-18 22:43 ` Dave Jiang [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-22 5:13 Stephen Rothwell
2023-08-22 13:59 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05caaa9-244b-a84f-88b2-2d6bfec61fdd@intel.com \
--to=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox