public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: haoxin <xhao@linux.alibaba.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	James Morse <james.morse@arm.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	lcherian@marvell.com, bobo.shaobowang@huawei.com,
	tan.shaopeng@fujitsu.com, Jamie Iles <quic_jiles@quicinc.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com
Subject: Re: [PATCH v5 00/21] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes
Date: Wed, 7 Sep 2022 13:46:17 +0800	[thread overview]
Message-ID: <a05e0397-50be-2f99-e461-60852c8efb3c@linux.alibaba.com> (raw)
In-Reply-To: <5adf4968-b079-2fd3-dd61-09ed16f74080@intel.com>


在 2022/8/24 上午1:09, Reinette Chatre 写道:
> Hi,
>
> On 7/3/2022 8:54 AM, Xin Hao wrote:
>> Hi  james,
>>
>> I have a review all of the patches, it looks goot to me, but i also test them once again, i have a little confusion with my test.
>>
>> # mkdir p1
>>
>> # echo "L3:0=001;1=001" > p1/schemata
>>
>> # [root@iZbp1bu26qv0j3ddyusot3Z p1]# cat schemata
>>      MB:0=100;1=100
>>      L3:0=001;1=001
>>
>> # memhog -r1000000 1000m > /mnt/log &
>>
>> [1] 53023
>> [root@iZbp1bu26qv0j3ddyusot3Z p1]# echo 53023 > tasks
>> [
>> [root@iZbp1bu26qv0j3ddyusot3Z p1]# cat mon_data/mon_L3_00/llc_occupancy
>> 3833856
>> [root@iZbp1bu26qv0j3ddyusot3Z p1]# cat mon_data/mon_L3_00/llc_occupancy
>> 3620864
>> [root@iZbp1bu26qv0j3ddyusot3Z p1]# cat mon_data/mon_L3_00/llc_occupancy
>> 3727360
>> [root@iZbp1bu26qv0j3ddyusot3Z p1]# cat size
>>      MB:0=100;1=100
>>      L3:0=3407872;1=3407872
>>
>> Obviously, the value has been overflowed,  Can you explain why?
> Are you seeing different behavior before and after you apply this
> series?
No,they have the same test result。
>
> I do not think the conclusion should immediately be that there is an
> overflow issue. Have you perhaps run into the scenario "Notes on
> cache occupancy monitoring and control" described in
> Documentation/x86/resctrl.rst?
>
> When "memhog" starts it can allocate to the entire L3 for a while
> before it is moved to the constrained resource group. It's cache
> lines are not evicted as part of this move so it is not unusual for
> it to have more lines in L3 than it is allowed to allocate into.

Yes as you said, the mon_data/mon_L3_00/llc_occupancy does not 
immediately become the value small than the set by schemata,  it may 
takes a few minutes to reduce to the set value.

I don't quite understand why it takes so long to see the llc_occupancy 
degrage.

>
> Understanding the occupancy values require understanding of the workload
> as well as the system environment.
>
> Depending on the workload's data usage (for example if it keeps loading
> new data - note that if the workload keeps loading the same data and the
> data is already present in an area of cache that the workload cannot
> allocate into then the data read would still result in a cache hit for the
> workload, the data would not be moved to the area the
> workload can allocate into) and other workloads on the system (there is
> other load present also that evicts the lines owned by the workload) the
> L3 occupancy rate should go down after a while to match the space it
> can allocate into.
>
> Reinette

  reply	other threads:[~2022-09-07  5:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 16:46 [PATCH v5 00/21] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes James Morse
2022-06-22 16:46 ` [PATCH v5 01/21] x86/resctrl: Kill off alloc_enabled James Morse
2022-06-22 16:46 ` [PATCH v5 02/21] x86/resctrl: Merge mon_capable and mon_enabled James Morse
2022-06-22 16:46 ` [PATCH v5 03/21] x86/resctrl: Add domain online callback for resctrl work James Morse
2022-06-22 16:46 ` [PATCH v5 04/21] x86/resctrl: Group struct rdt_hw_domain cleanup James Morse
2022-06-29  8:33   ` tan.shaopeng
2022-06-29 11:07     ` James Morse
2022-07-01  6:37       ` tan.shaopeng
2022-06-22 16:46 ` [PATCH v5 05/21] x86/resctrl: Add domain offline callback for resctrl work James Morse
2022-06-22 16:46 ` [PATCH v5 06/21] x86/resctrl: Remove set_mba_sc()s control array re-initialisation James Morse
2022-06-22 16:46 ` [PATCH v5 07/21] x86/resctrl: Abstract and use supports_mba_mbps() James Morse
2022-08-23 16:42   ` Reinette Chatre
2022-06-22 16:46 ` [PATCH v5 08/21] x86/resctrl: Create mba_sc configuration in the rdt_domain James Morse
2022-06-22 16:46 ` [PATCH v5 09/21] x86/resctrl: Switch over to the resctrl mbps_val list James Morse
2022-06-22 16:46 ` [PATCH v5 10/21] x86/resctrl: Remove architecture copy of mbps_val James Morse
2022-06-22 16:46 ` [PATCH v5 11/21] x86/resctrl: Allow update_mba_bw() to update controls directly James Morse
2022-06-22 16:46 ` [PATCH v5 12/21] x86/resctrl: Calculate bandwidth from the previous __mon_event_count() chunks James Morse
2022-06-22 16:46 ` [PATCH v5 13/21] x86/resctrl: Add per-rmid arch private storage for overflow and chunks James Morse
2022-06-22 16:46 ` [PATCH v5 14/21] x86/resctrl: Allow per-rmid arch private storage to be reset James Morse
2022-06-22 16:46 ` [PATCH v5 15/21] x86/resctrl: Abstract __rmid_read() James Morse
2022-06-22 16:46 ` [PATCH v5 16/21] x86/resctrl: Pass the required parameters into resctrl_arch_rmid_read() James Morse
2022-06-22 16:46 ` [PATCH v5 17/21] x86/resctrl: Move mbm_overflow_count() " James Morse
2022-06-22 16:46 ` [PATCH v5 18/21] x86/resctrl: Move get_corrected_mbm_count() " James Morse
2022-06-22 16:46 ` [PATCH v5 19/21] x86/resctrl: Rename and change the units of resctrl_cqm_threshold James Morse
2022-06-22 16:46 ` [PATCH v5 20/21] x86/resctrl: Add resctrl_rmid_realloc_limit to abstract x86's boot_cpu_data James Morse
2022-06-22 16:46 ` [PATCH v5 21/21] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes James Morse
2022-07-03 15:54 ` [PATCH v5 00/21] " Xin Hao
2022-08-23 17:09   ` Reinette Chatre
2022-09-07  5:46     ` haoxin [this message]
2022-09-08 17:01       ` James Morse
2022-08-23 17:20 ` Reinette Chatre
2022-09-02 15:47   ` James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a05e0397-50be-2f99-e461-60852c8efb3c@linux.alibaba.com \
    --to=xhao@linux.alibaba.com \
    --cc=Babu.Moger@amd.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bobo.shaobowang@huawei.com \
    --cc=bp@alien8.de \
    --cc=cristian.marussi@arm.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=quic_jiles@quicinc.com \
    --cc=reinette.chatre@intel.com \
    --cc=scott@os.amperecomputing.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xingxin.hx@openanolis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox