From: Marek Vasut <marek.vasut@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: mtd/ftl: Use kmalloc_array() in build_maps()
Date: Thu, 12 Jan 2017 17:58:32 +0100 [thread overview]
Message-ID: <a07556ec-df86-ae87-002d-74ebcd79c7df@gmail.com> (raw)
In-Reply-To: <e2e1d30e-b81f-d034-b266-37fec409350d@users.sourceforge.net>
On 01/12/2017 05:50 PM, SF Markus Elfring wrote:
>> The indentation has been changed and the new one looks wrong...
>
> The source code formatting contained various open issues before already.
>
>
>> If you want to fix the indentation to make it compliant with the Linux
>> coding style, do it on the whole file so every thing is uniform.
>
> Such a development task is too much for me today.
Let me officially NAK this patch.
>> Reviewing such dummy/automatic patches is a pure waste of time,
>> so personally I think we should just ignore them.
>
> How much do you care for the usage of a function like “kmalloc_array”?
Not at all, there are more pressing issues.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-01-12 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 10:33 [PATCH 0/3] MTD-FTL: Fine-tuning for two function implementations SF Markus Elfring
2017-01-12 10:35 ` [PATCH 1/3] mtd/ftl: Use kmalloc_array() in build_maps() SF Markus Elfring
2017-01-12 13:00 ` Cyrille Pitchen
2017-01-12 16:50 ` SF Markus Elfring
2017-01-12 16:58 ` Marek Vasut [this message]
2017-01-13 9:32 ` [PATCH 1/3] " kbuild test robot
2017-01-12 10:36 ` [PATCH 2/3] mtd/ftl: Delete an error message for a failed memory allocation in ftl_add_mtd() SF Markus Elfring
2017-01-12 10:38 ` [PATCH 3/3] mtd/ftl: Improve another size determination " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07556ec-df86-ae87-002d-74ebcd79c7df@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox