From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751129AbdALQ6x (ORCPT ); Thu, 12 Jan 2017 11:58:53 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34906 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdALQ6g (ORCPT ); Thu, 12 Jan 2017 11:58:36 -0500 Subject: Re: mtd/ftl: Use kmalloc_array() in build_maps() To: SF Markus Elfring , Cyrille Pitchen , linux-mtd@lists.infradead.org References: <4a5a265e-96c8-5fe6-487a-92a0d47a91da@users.sourceforge.net> <4be87294-5e91-5ced-770f-8630ccab689a@atmel.com> Cc: Boris Brezillon , Richard Weinberger , kernel-janitors@vger.kernel.org, LKML , Brian Norris , David Woodhouse From: Marek Vasut Message-ID: Date: Thu, 12 Jan 2017 17:58:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2017 05:50 PM, SF Markus Elfring wrote: >> The indentation has been changed and the new one looks wrong... > > The source code formatting contained various open issues before already. > > >> If you want to fix the indentation to make it compliant with the Linux >> coding style, do it on the whole file so every thing is uniform. > > Such a development task is too much for me today. Let me officially NAK this patch. >> Reviewing such dummy/automatic patches is a pure waste of time, >> so personally I think we should just ignore them. > > How much do you care for the usage of a function like “kmalloc_array”? Not at all, there are more pressing issues. -- Best regards, Marek Vasut