* [PATCH] s390/dasd: Use IS_ERR_OR_NULL() to simplify code
@ 2025-08-14 13:12 Liao Yuanhong
2025-08-15 14:13 ` Stefan Haberland
0 siblings, 1 reply; 2+ messages in thread
From: Liao Yuanhong @ 2025-08-14 13:12 UTC (permalink / raw)
To: Stefan Haberland, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
open list:S390 DASD DRIVER, open list
Cc: Liao Yuanhong
Use IS_ERR_OR_NULL() instead of the original !xxx || IS_ERR(xxx) logic.
This will simplify the code and enhance readability.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/s390/block/dasd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 506a947d00a5..78a9c8d781b3 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -215,7 +215,7 @@ static struct dentry *dasd_debugfs_setup(const char *name,
if (!base_dentry)
return NULL;
pde = debugfs_create_dir(name, base_dentry);
- if (!pde || IS_ERR(pde))
+ if (IS_ERR_OR_NULL(pde))
return NULL;
return pde;
}
@@ -1089,11 +1089,11 @@ static void dasd_statistics_createroot(void)
dasd_debugfs_root_entry = NULL;
pde = debugfs_create_dir("dasd", NULL);
- if (!pde || IS_ERR(pde))
+ if (IS_ERR_OR_NULL(pde))
goto error;
dasd_debugfs_root_entry = pde;
pde = debugfs_create_dir("global", dasd_debugfs_root_entry);
- if (!pde || IS_ERR(pde))
+ if (IS_ERR_OR_NULL(pde))
goto error;
dasd_debugfs_global_entry = pde;
dasd_profile_init(&dasd_global_profile, dasd_debugfs_global_entry);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/dasd: Use IS_ERR_OR_NULL() to simplify code
2025-08-14 13:12 [PATCH] s390/dasd: Use IS_ERR_OR_NULL() to simplify code Liao Yuanhong
@ 2025-08-15 14:13 ` Stefan Haberland
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Haberland @ 2025-08-15 14:13 UTC (permalink / raw)
To: Liao Yuanhong, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
open list:S390 DASD DRIVER, open list, Yang Xiuwei
Am 14.08.25 um 15:12 schrieb Liao Yuanhong:
> Use IS_ERR_OR_NULL() instead of the original !xxx || IS_ERR(xxx) logic.
> This will simplify the code and enhance readability.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
The exact same patch was already submitted by Yang Xiuwei <yangxiuwei@kylinos.cn> before.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-15 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 13:12 [PATCH] s390/dasd: Use IS_ERR_OR_NULL() to simplify code Liao Yuanhong
2025-08-15 14:13 ` Stefan Haberland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).