From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932265AbcHIJ46 (ORCPT ); Tue, 9 Aug 2016 05:56:58 -0400 Received: from mout.web.de ([212.227.15.14]:53517 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbcHIJ44 (ORCPT ); Tue, 9 Aug 2016 05:56:56 -0400 Subject: Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() To: Lee Jones References: <4dcb4cab-e2cc-87c0-9cfc-d140f185254b@users.sourceforge.net> <20160805075511.GN5243@dell> <0a2ef320-a95a-2611-2554-a2a83838fb9b@users.sourceforge.net> <20160809093022.GU5243@dell> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Tue, 9 Aug 2016 11:56:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160809093022.GU5243@dell> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:kfLT2SQEF+kFy2JJmrRy7q9xUz5444POTALQf/rbGuQiY51u4Rk 0x3qA5NseqJsgcD8FgOBTIDAOh20K/4dM0okxfh2dpl4L7EroShXj2g7Du3TEWyEUWDpPQN 4RDVxeqJwOY4C+Ph1LZ6fFkCqMVMF7wgI7Ix/00Y1Xggh6dtxubuEqTip1p8W5z++qWOiwN drpDfEMhnG4UqXwyi6+rA== X-UI-Out-Filterresults: notjunk:1;V01:K0:LtyPTtMvw/A=:5Ib/GWWM5nyX+3+qcJB5kK ichgJGNyOJLiov+e5rBcIxryaaTu0AJylSTfOElPcXoYOZxnBO7ygOLXB8o9KsSLk+jzd1cko Xn9pLxCIXzmzkv3LVu8lijDOvkexksQrUrvWopXf+bYV11MaErhHGCl2hEYdEViXBVcmnSTC2 hDtugNSJbtNCBDlUcrAcOb/0mDmu3kZFJKcwG2NoCgXTrDwunL2NAPdfoa6h7Yn11WMtsSt28 ZqezLitpSfl9ozXpFlEDTdakATi4E4exoLFLvhUQtD4X0BB5VNLd6GrzVNx32gVHx7aolQZL1 g36rTCRRtJXPirEh5YP5vnGZd4Hi7MiLoiPMLTzCf5qZNxHaSbBD+1FII4MZH1oCJdJ3V4giu X9NEGCIMKVnSYp6KVp9KDPlsLXI/aZdFPiZAjCUbFzZ0m8FD/27DA9F+zqnq40bfTWlr9ZkrW Y8aCGMLkcUOGpBQENNdK7cNi8NHKkGxUN+LQXzI9jBAm7Mq/6vcdxK5Icx5Ach3wxPfACAISV FYmlADUzwl8tVBbUg/extCDukmXtfSbhf6mb2EzZ15QGEwPvgIWshvg+9/B9gVAnzqmqV3l0h pPLxSEe34XggRuJDae+hRhnYOat4Iz1V1Lh5iUDiEOnENHWdbO8/UQ/8+2n/y10EqkwbJa3Oh W6wmDvDTEDMAcApYBzDKX4gWSZlwWK1pjjKu8N2oSIqaayHYuUFkAR7Fof9HBmCylM9T02qYw LnKyyxl3OMZLZTY5ufrNz+hzOSEB2AAuSgfezjqEw7VHVNpH36E6vrUrOKAsgxqNr9ZTKiN3D UylUbCB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > But the change-log in this patch says "I did some stuff". > What stuff did you change? Which review comments did you > tend to? I imagine that I could increase the description granularity to a detail level which you might also not like. >>>> +put_device: >>>> + platform_device_put(pdev); >>>> + dev_err(&client->dev, "failed to add device %s\n", name); >>> >>> ... and remove this line. >> >> Do you really want that this error message should be deleted? >> >> How does this response fit to your request to introduce such a message >> for the function "add_numbered_child" (on 2016-06-08)? >> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1162299.html >> https://lkml.org/lkml/2016/6/8/467 > > You've lost the context. I interpreted the suggested message adjustments as separate changes. So I wondered about a different handling for the Linux modules "dm355evm_msp" and "twl-core". > The "..." is meant to intimate that it > follows on from a previous comment. In this case: > >> > status = platform_device_add_data(pdev, pdata, pdata_len); >> > if (status < 0) { >> > dev_dbg(&pdev->dev, "can't add platform_data\n"); >> >> Please take the opportunity to convert these to dev_err()s. > > So, convert the specific dev_dbg() calls to dev_err() and remove the > contentless one at the bottom. It seems then that you would like to get rid of an error message at the end while increasing the importance of a related information. Regards, Markus