From: Mikulas Patocka <mpatocka@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jens Axboe <axboe@kernel.dk>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] dm table: Fix W=1 build warning when mempool_needs_integrity is unused
Date: Mon, 14 Apr 2025 14:13:18 +0200 (CEST) [thread overview]
Message-ID: <a0b1fcbf-9cda-9da2-ecbe-ac5cbc75b775@redhat.com> (raw)
In-Reply-To: <Z_zd1NCtn_QxaCzC@smile.fi.intel.com>
On Mon, 14 Apr 2025, Andy Shevchenko wrote:
> On Mon, Apr 14, 2025 at 01:04:49PM +0300, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 10:21:26AM +0300, Andy Shevchenko wrote:
> > > The mempool_needs_integrity is unused. This, in particular, prevents
> > > kernel builds with Clang, `make W=1` and CONFIG_WERROR=y:
> > >
> > > drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable]
> > > 1052 | bool mempool_needs_integrity = t->integrity_supported;
> > > | ^
> > >
> > > Fix this by removing the leftover.
> >
> > This issue is still present in v6.15-rc1.
>
> I meant v6.15-rc2, of course.
>
> --
> With Best Regards,
> Andy Shevchenko
I will send it to Linus (maybe with other changes) before 6.15 comes out.
Mikulas
next prev parent reply other threads:[~2025-04-14 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:21 [PATCH v1 1/1] dm table: Fix W=1 build warning when mempool_needs_integrity is unused Andy Shevchenko
2025-04-14 10:04 ` Andy Shevchenko
2025-04-14 10:05 ` Andy Shevchenko
2025-04-14 12:13 ` Mikulas Patocka [this message]
2025-04-15 6:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0b1fcbf-9cda-9da2-ecbe-ac5cbc75b775@redhat.com \
--to=mpatocka@redhat.com \
--cc=agk@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox