From: David Laight <David.Laight@ACULAB.COM>
To: 'Peter Zijlstra' <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: RE: Buggy __free(kfree) usage pattern already in tree
Date: Wed, 20 Sep 2023 11:02:51 +0000 [thread overview]
Message-ID: <a0ba32c892654a2bb60327e103d181fb@AcuMS.aculab.com> (raw)
In-Reply-To: <20230919193516.GA20937@noisy.programming.kicks-ass.net>
If this stuff is so hard to get right for non-trivial cases
perhaps it should all be ripped out?
The trivial cases are pretty easy to eve-ball check and
static analysis tools do a reasonable job.
Maybe I'm 'old-school' but I'd much rather see explicit
unlock() and free() than have 'some compiler magic' do
it for you.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-09-20 11:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 9:56 Buggy __free(kfree) usage pattern already in tree Alexey Dobriyan
2023-09-15 10:09 ` Bartosz Golaszewski
2023-09-15 17:04 ` Linus Torvalds
2023-09-15 17:22 ` Bartosz Golaszewski
2023-09-15 19:06 ` Linus Torvalds
2023-09-15 19:27 ` Bartosz Golaszewski
2023-09-15 20:03 ` Bartosz Golaszewski
2023-09-15 20:40 ` Linus Torvalds
2023-09-15 21:08 ` Peter Zijlstra
2023-09-15 21:18 ` Peter Zijlstra
2023-09-15 21:25 ` Linus Torvalds
2023-09-15 21:22 ` Linus Torvalds
2023-09-15 21:32 ` Peter Zijlstra
2023-09-15 21:50 ` Linus Torvalds
2023-09-15 22:10 ` Linus Torvalds
2023-09-15 22:13 ` Peter Zijlstra
2023-09-19 12:57 ` Peter Zijlstra
2023-09-19 12:59 ` Peter Zijlstra
2023-09-19 13:10 ` Peter Zijlstra
2023-09-19 19:35 ` Peter Zijlstra
2023-09-20 11:02 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0ba32c892654a2bb60327e103d181fb@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox