Re: [PATCH v1 04/11] KVM: x86: use u16 for logical VCPU mask in lapic

Paolo Bonzini
2016-07-01T14:16:09Z

On 01/07/2016 14:48, Radim Krčmář wrote:
> The other callsite in kvm_irq_delivery_to_apic() does not pass 16:
>
> int idx = kvm_vector_to_index(irq->vector, dest_vcpus,
> dest_vcpu_bitmap, KVM_MAX_VCPUS);

Ah, missed it.

> kvm_vector_to_index() uses find_next_bit(), so we would have two casts
> if we changed the type. This patch is not really needed, so I could
> drop it instead.

Yes, let's leave it aside (and then you don't have to put it before
patch 2!).

Paolo