From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59F5C433DB for ; Wed, 27 Jan 2021 11:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7139B2076B for ; Wed, 27 Jan 2021 11:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236994AbhA0Lku (ORCPT ); Wed, 27 Jan 2021 06:40:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:36614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237105AbhA0LjE (ORCPT ); Wed, 27 Jan 2021 06:39:04 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75D552075B; Wed, 27 Jan 2021 11:38:23 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l4j9R-00AMFp-7U; Wed, 27 Jan 2021 11:38:21 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Jan 2021 11:38:21 +0000 From: Marc Zyngier To: Biwen Li Cc: mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org, ran.wang_1@nxp.com, Biwen Li Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace In-Reply-To: <20210127085818.23742-1-biwen.li@oss.nxp.com> References: <20210127085818.23742-1-biwen.li@oss.nxp.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: biwen.li@oss.nxp.com, mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org, ran.wang_1@nxp.com, biwen.li@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-27 08:58, Biwen Li wrote: > From: Biwen Li > > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, > ... > [ 45.605239] Unbalanced IRQ 120 wake disable > [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 > irq_set_irq_wake+0x154/0x1a0 > ... > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0 > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0 > ... > [ 45.742825] Call trace: > [ 45.745268] irq_set_irq_wake+0x154/0x1a0 > [ 45.749278] ds3232_resume+0x38/0x50 > > On ls2088ardb: > In suspend progress(# echo mem > /sys/power/state), > pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend() > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake() > ->set_irq_wake_real(), return -ENXIO, there get > "Cannot set wakeup source" in ds3232_suspend(). > > In resume progress(wakeup by flextimer) > dpm_resume_end()->dpm_resume() > ->device_resume()->ds3232_resume() > ->disable_irq_wake()->irq_set_irq_wake() > ->set_irq_wake_real(), there get > kernel call trace(Unbalanced IRQ 120 wake > disable) This is again paraphrasing the stack trace instead of explaining the problem it fixes. How about: "The ls-extirq driver doesn't implement the irq_set_wake() callback, while being wake-up capable. This results in ugly behaviours across suspend/resume cycles. Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip flags" The subject line should be fixed along the same lines, and a Fixes: tag added. M. -- Jazz is not dead. It just smells funny...