From: Stephen Boyd <sboyd@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Michael Turquette <mturquette@baylibre.com>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: renesas: fix r9a09g057_cpg_info link error
Date: Wed, 07 Aug 2024 13:52:22 -0700 [thread overview]
Message-ID: <a0c8bb91f1645d1769e4cd2945bf36f8.sboyd@kernel.org> (raw)
In-Reply-To: <20240807075714.2156445-1-arnd@kernel.org>
Quoting Arnd Bergmann (2024-08-07 00:56:58)
> From: Arnd Bergmann <arnd@arndb.de>
>
> The rzv2g-cpg.c driver unconditionally links into the r9a09g057
> one, but that may be disabled:
>
> aarch64-linux-ld: drivers/clk/renesas/rzv2h-cpg.o:(.rodata+0x440): undefined reference to `r9a09g057_cpg_info'
>
> Use the same approach here as with the rzg2l variant, using an #ifdef
> around tha data.
>
> I think both drivers would be better off doing the abstraction the other
> way round, with the platform_driver structure defined in the most specific
> file and the common bits as a library that exports common functions.
> Changing it that way would require a larger rework of course.
>
> Fixes: 42b54d52ecb7 ("clk: renesas: Add RZ/V2H(P) CPG driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
This is https://lore.kernel.org/r/20240805095842.277792-1-prabhakar.mahadev-lad.rj@bp.renesas.com
prev parent reply other threads:[~2024-08-07 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 7:56 [PATCH] clk: renesas: fix r9a09g057_cpg_info link error Arnd Bergmann
2024-08-07 20:52 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c8bb91f1645d1769e4cd2945bf36f8.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox