From: Paul Walmsley <pjw@kernel.org>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
Andrew Jones <ajones@ventanamicro.com>
Subject: Re: [PATCH v5 2/3] riscv: Strengthen duplicate and inconsistent definition of RV_X()
Date: Fri, 12 Sep 2025 19:30:29 -0600 (MDT) [thread overview]
Message-ID: <a0ca072b-74fd-82b6-1e7f-e15183d0495b@kernel.org> (raw)
In-Reply-To: <20250620-dev-alex-insn_duplicate_v5_manual-v5-2-d865dc9ad180@rivosinc.com>
On Fri, 20 Jun 2025, Alexandre Ghiti wrote:
> RV_X() macro is defined in two different ways which is error prone.
>
> So harmonize its first definition and add another macro RV_X_mask() for
> the second one.
>
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Thanks. I updated this one to uppercase the name of the RV_X_MASK macro.
That way it matches the naming of the rest of the macros in the file.
Queued for v6.18.
- Paul
next prev parent reply other threads:[~2025-09-13 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 20:21 [PATCH v5 0/3] Move duplicated instructions macros into asm/insn.h Alexandre Ghiti
2025-06-20 20:21 ` [PATCH v5 1/3] riscv: Fix typo EXRACT -> EXTRACT Alexandre Ghiti
2025-06-20 20:21 ` [PATCH v5 2/3] riscv: Strengthen duplicate and inconsistent definition of RV_X() Alexandre Ghiti
2025-09-13 1:30 ` Paul Walmsley [this message]
2025-06-20 20:21 ` [PATCH v5 3/3] riscv: Move all duplicate insn parsing macros into asm/insn.h Alexandre Ghiti
2025-06-23 8:07 ` [PATCH v5 0/3] Move duplicated instructions " Clément Léger
2025-06-23 8:48 ` Alexandre Ghiti
2025-06-25 14:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0ca072b-74fd-82b6-1e7f-e15183d0495b@kernel.org \
--to=pjw@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).