From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9255D37C0F5 for ; Fri, 23 Jan 2026 04:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769141246; cv=none; b=Bs4hdmJiSUz2BujFuq/Tcvs9dRaLJzDfCgdNTlRzrCa41mD+D5Zbbx67ND5aU0V/0Uw3TKSd40MH0mWrRapTyFQh7vhvdFqncaMUnc/PsmLSWlPr7P8mzgBZDFU3Y3pDQW8ucvLQygkS5jhc6JVf6Fs04At8CJ+JLzg1OVlHTZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769141246; c=relaxed/simple; bh=v6kZZe7ybcJOjR9F1ZeiyHnchWeMvm5tLOBTEA5FXpI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s3EFn6VLW6ZWOO8BeDFJ12u33DoRmwuXwAXmob9eHVzwWOHaEVkSGb5kMO/1yojCkGl77QSPM5d9k9edII9xGpCovZAxmRrCW25+G0UAkLYxMr6OsuBJ6ojFqbW+6FbWLeS+knt0MXGIHrJtPm8pfNoYiffoZ5+co0MyvwJNsr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cPxbhWJP; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cPxbhWJP" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1769141227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/UdGSl1zFpyYo7ZLism+9vO/YeG3Eo+vsrATosec5nQ=; b=cPxbhWJPP5B2CyugGIqAuhz8oDEcxXLVkBcTMAYNhDWaNyc4IBpuNcwyu9xHAR5/66xOAn VnIPu6PvOBzokmE1gkoZCHpSmqOR6xzbaosA4w5U46YP19U45z8FyVR/AW0Qed6XS5F6GJ 0qh+UnZQImb4WBhZ6DzaJeky9Ws4sio= Date: Fri, 23 Jan 2026 12:06:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v7 2/9] libbpf: Add support for extended bpf syscall Content-Language: en-US To: Alexei Starovoitov Cc: bpf , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Christian Brauner , Seth Forshee , Yuichiro Tsuji , Andrey Albershteyn , Willem de Bruijn , Jason Xing , Tao Chen , Mykyta Yatsenko , Kumar Kartikeya Dwivedi , Anton Protopopov , Amery Hung , Rong Tao , LKML , Linux API , "open list:KERNEL SELFTEST FRAMEWORK" , kernel-patches-bot@fb.com References: <20260123032445.125259-1-leon.hwang@linux.dev> <20260123032445.125259-3-leon.hwang@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 23/1/26 11:55, Alexei Starovoitov wrote: > On Thu, Jan 22, 2026 at 7:25 PM Leon Hwang wrote: >> >> >> +static int probe_bpf_syscall_common_attrs(int token_fd) >> +{ >> + int ret; >> + >> + ret = probe_sys_bpf_ext(); >> + return ret > 0; >> +} > > When you look at the above, what thoughts come to mind? > > ... and please don't use ai for answers. My initial thought was whether probe_fd() is needed here to handle and close a returned fd, since the return value of probe_sys_bpf_ext() isn’t obvious from the call site. Thanks, Leon