From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: "Longbin Li" <looong.bin@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen Wang" <unicorn_wang@outlook.com>,
"Inochi Amaoto" <inochiama@gmail.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [External] : [PATCH v2 3/3] pwm: sophgo: add driver for SG2044
Date: Fri, 18 Apr 2025 20:41:04 +0530 [thread overview]
Message-ID: <a0d63c0d-7f17-459a-9ba1-6532a986c8db@oracle.com> (raw)
In-Reply-To: <20250418022948.22853-4-looong.bin@gmail.com>
On 18-04-2025 07:59, Longbin Li wrote:
> +#define SG2044_REG_POLARITY 0x40
> +#define SG2044_REG_PWMSTART 0x44
> +#define SG2044_REG_PWM_OE 0xD0
> +
please use lowercase 0xd0
> #define SG2042_PWM_HLPERIOD(chan) ((chan) * 8 + 0)
> #define SG2042_PWM_PERIOD(chan) ((chan) * 8 + 4)
Thanks,
Alok
next prev parent reply other threads:[~2025-04-18 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 2:29 [PATCH v2 0/3] riscv: pwm: sophgo: add pwm support for SG2044 Longbin Li
2025-04-18 2:29 ` [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller " Longbin Li
2025-04-19 1:13 ` Chen Wang
2025-04-22 13:56 ` Rob Herring
2025-04-18 2:29 ` [PATCH v2 2/3] pwm: sophgo: reorganize the code structure Longbin Li
2025-04-19 1:20 ` Chen Wang
2025-04-18 2:29 ` [PATCH v2 3/3] pwm: sophgo: add driver for SG2044 Longbin Li
2025-04-18 15:11 ` ALOK TIWARI [this message]
2025-04-19 1:01 ` [External] : " Longbin Li
2025-04-19 1:24 ` Chen Wang
2025-04-19 7:36 ` Longbin Li
2025-04-19 1:27 ` [PATCH v2 0/3] riscv: pwm: sophgo: add pwm support " Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0d63c0d-7f17-459a-9ba1-6532a986c8db@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=ukleinek@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox