Re: [PATCH v4 05/24] smb: move some duplicate definitions to common/smb1pdu.h

Namjae Jeon
2025-10-28T04:02:59Z

On Tue, Oct 28, 2025 at 12:58 PM ChenXiaoSong
<chenxiaosong.chenxiaosong@linux.dev> wrote:
>
> Would it be harder to maintain if only part of the definitions are moved?
>
> Moving the related definitions together would make maintenance easier,
> that's just my personal opinion.
Please check Steve's reply on another mail thread.
If you think it looks weird, don't move them.

>
> On 10/28/25 11:42 AM, Namjae Jeon wrote:
> > On Mon, Oct 27, 2025 at 4:15 PM <chenxiaosong.chenxiaosong@linux.dev> wrote:
> >>
> >> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
> >>
> >> In order to maintain the code more easily, move duplicate definitions to
> >> new common header file.
> >>
> >> Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
> >> Suggested-by: Namjae Jeon <linkinjeon@kernel.org>
> > ksmbd does not use all smb1 pdus. Instead of moving all smb1 definitions,
> > move the ones ksmbd uses to smb1pdu.h.
> > Thanks.
>
> --
> Thanks,
> ChenXiaoSong.
>