Re: [PATCH v4 19/24] smb/server: remove create_durable_reconn_req

Namjae Jeon
2025-10-29T03:54:24Z

On Mon, Oct 27, 2025 at 4:23 PM <chenxiaosong.chenxiaosong@linux.dev> wrote:
>
> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
>
> The fields in struct create_durable_reconn_req and struct create_durable
> are exactly the same.
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
> ---
> fs/smb/server/smb2pdu.c | 6 +++---
> fs/smb/server/smb2pdu.h | 12 ------------
> 2 files changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
> index 6b3503c7bfaa..3e8344fa163b 100644
> --- a/fs/smb/server/smb2pdu.c
> +++ b/fs/smb/server/smb2pdu.c
> @@ -2766,7 +2766,7 @@ static int parse_durable_handle_context(struct ksmbd_work *work,
> }
> case DURABLE_RECONN:
> {
> - struct create_durable_reconn_req *recon;
> + struct create_durable *recon;
>
> if (dh_info->type == DURABLE_RECONN_V2 ||
> dh_info->type == DURABLE_REQ_V2) {
> @@ -2776,12 +2776,12 @@ static int parse_durable_handle_context(struct ksmbd_work *work,
>
> if (le16_to_cpu(context->DataOffset) +
> le32_to_cpu(context->DataLength) <
> - sizeof(struct create_durable_reconn_req)) {
> + sizeof(struct create_durable)) {
Please check the specification, Which structure name is correct?
thanks.