public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@redhat.com>, Paul Mackerras <paulus@samba.org>,
	Roland McGrath <roland@redhat.com>
Subject: Re: [POWERPC] Fix for assembler -g
Date: Sat, 25 Aug 2007 15:56:39 +0200	[thread overview]
Message-ID: <a113ea3591b48381b12f50dea9de29d4@kernel.crashing.org> (raw)
In-Reply-To: <20070825130210.GC15183@uranus.ravnborg.org>

>>>> But there is no lparmap.o!  lparmap.s is the generated file.
>>>
>>> Yeah, tell that to scripts/Makefile.lib:
>>>
>>> 	_c_flags       = $(CFLAGS) $(EXTRA_CFLAGS) $(CFLAGS_$(basetarget).o)
>>>
>>> What would do what a person expects is $(CFLAGS_$(@F)), I think.
>>
>> Looks good to me.  Sam?  We wanted to set CFLAGS_lparmap.s .
>
> To avoid confusion (in most cases) setting CFLAGS_file.o
> does the expected thing in case on .o, .s, .lst and .i targets.
> So the general and easy to remember rule is to set CFLAGS_file.o
> and then kbuild takes care of the rest.

Yeah, that makes sense in the "normal" case.  In this case, the
generated .s file is actually used in the build process though,
so it was a bit confusing.

> I assume you already did so and it solved your problem - no?

Sure, it was just a question "is this the right thing or not".
In any case, the problematic thing will be removed completely
here :-)

Thanks for the explanation, it all makes sense now,


Segher


  reply	other threads:[~2007-08-25 13:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200708181959.l7IJxJ5q020206@hera.kernel.org>
2007-08-20 20:08 ` [POWERPC] Fix for assembler -g Dave Jones
2007-08-20 20:18   ` Roland McGrath
2007-08-20 20:23     ` Dave Jones
2007-08-20 21:29       ` Segher Boessenkool
2007-08-20 21:35         ` Roland McGrath
2007-08-20 22:26           ` Segher Boessenkool
2007-08-20 21:28     ` Segher Boessenkool
2007-08-20 21:32       ` Roland McGrath
2007-08-20 22:29         ` Segher Boessenkool
2007-08-25 13:02           ` Sam Ravnborg
2007-08-25 13:56             ` Segher Boessenkool [this message]
2007-08-20 23:14     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a113ea3591b48381b12f50dea9de29d4@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=roland@redhat.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox