Re: [PATCH] configs/debug: Refresh debug config dependencies

[Matthieu Baerts <matttbe@kernel.org>]

Hi Kees,

Thank you for sharing this patch!

On 22/04/2025 18:54, Kees Cook wrote:
> Many of the CONFIG_DEBUG* options need CONFIG_DEBUG_KERNEL=y to be set,

Good point! I guess it has not been seen before because it is usually
enabled in the different _defconfig files. So probably no need to
backport this I guess, right?


> so enable it explicitly. Similarly for CONFIG_NET* options, enable
> CONFIG_NET=y.

I'm not sure about that one: if I'm not mistaken, the net debugging
options have been added for CIs using network features, to find bugs in
this area. In other words, I don't think it is needed to add a
dependence to CONFIG_NET. If it is enabled, then some extra debugging
options should be enabled to get more debug. If not, no need to force
having CONFIG_NET, no?

(On the other hand, CONFIG_NET is very likely needed for a CI, and it is
typically enabled in the different _defconfig and kvm_guest.config. I
guess adding this dependence will very likely not annoy anybody, so up
to you :) )


> Finally, remove CONFIG_DEBUG_VM_VMACACHE, since it was
> removed in commit 7964cf8caa4d ("mm: remove vmacache").

Good catch!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.