Re: [PATCH v2 0/2] PCI: vmd: Fix two issues in VMD reported by Smatch

Krzysztof Wilczyński
2023-06-24T16:33:22Z

[+CC Christoph]

Hello,

> Fix two issues when building kernel with Smatch check.
>
> v1->v2:
> According to Damien's suggestion, I split it from 1 patch to 2 different
> patches. Change 'inconsistent indenting' patch's title from 'fix' to
> 'clean up'.
>
> Xinghui Li (2):
> PCI: vmd: Fix one uninitialized symbol error reported by Smatch

Applied to controller/vmd, thank you!

[1/1] PCI: vmd: Fix uninitialized variable usage in vmd_enable_domain()
https://git.kernel.org/pci/pci/c/0c0206dc4f5b

> PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch

Even though this is a very nice clean-up, I did not take this patch at this
time, as there has been a similar patch posted in the past, and Christoph
Hellwig suggested, as part of his review, an alternative approach worth
considering.

Have a look at the following and let me know what you think:

https://patchwork.kernel.org/project/linux-pci/patch/20221115054847.77829-1-jiapeng.chong@linux.alibaba.com/

Krzysztof