Re: [PATCH v2 0/2] PCI: vmd: Fix two issues in VMD reported by Smatch

Krzysztof Wilczyński
2023-06-25T17:04:03Z

Hello,

> > > PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch
> >
> > Even though this is a very nice clean-up, I did not take this patch at this
> > time, as there has been a similar patch posted in the past, and Christoph
> > Hellwig suggested, as part of his review, an alternative approach worth
> > considering.
> >
> > Have a look at the following and let me know what you think:
> >
> > https://patchwork.kernel.org/project/linux-pci/patch/20221115054847.77829-1-jiapeng.chong@linux.alibaba.com/
>
> I think Christoph Hellwig's suggestion is indeed better.
> So, should I submit a new patch to address this issue?

Please. A single new patch would suffice.

Make sure to explain as part of the commit log why this specific change
that started as a Smatch complaint about an incorrect indentation.

Thank you!

Krzysztof