From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbcIDR5Z (ORCPT ); Sun, 4 Sep 2016 13:57:25 -0400 Received: from mout.web.de ([212.227.15.3]:63125 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbcIDR5U (ORCPT ); Sun, 4 Sep 2016 13:57:20 -0400 Subject: [PATCH 1/4] perf/x86/cqm: Use kmalloc_array() in intel_mbm_init() To: x86@kernel.org, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Peter Zijlstra , Richard Cochran , Stephane Eranian , Thomas Gleixner , Tony Luck , Vikas Shivappa References: <566ABCD9.1060404@users.sourceforge.net> <9d893198-dd12-14a8-74bd-02fc42de4bf4@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sun, 4 Sep 2016 19:54:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <9d893198-dd12-14a8-74bd-02fc42de4bf4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:0+3q0s9FFyL1i7DVlZkrv4PunkHGkljJFf7La7vzJl+kcZR5Q7Q uEchk2Tbzz9QOU7nzpnHGBvIHz0nRlk8Vcel3s57O8bokeU3WHytGzuJK9PKdjYUFMmvr9u cly2a4N90zS9QzlK/4ByX5pxRxPgYt/Qn571cWfAFtffknY2uDf0F1N1Q1BqpLzTBAc21Xo wZnjDJOJGC69GcvgYwDdw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Gn4NTqe0z9k=:eOw3xX3wRp5K0W2FHYJ8ZG WKo5gf7yz+CdqaUJ49R2sbG+utM0NPMcJz6YVcz4sJd24WPrJ1G3Pt/ef//NSgvTdB2FF5d1V vxuTxUci4KvTUjJKmu40y+QwRZIo+DWMcitberRSJLbr+0kcnUEdQB+qDYe92kng22kwafT7q t6qVLbYLtZAHMwRA9wf2HcmJCUqeKxXGctn6aHLiuXTFSckEo4AGBNQEoL4BDLMtbl/J7B8L2 nP5SDOhw+L4f5ZyfLjv0iv2rDQ6avATJ2RKVlEy/z3mfYHVEZ8M/ZqwDMNuPgQTxj6jEeD5jc GWU0JnhNV8ZzzNw2vrXlC/757g/nWDjO3Jb7lsU0gFBZkNRyR0frPNgmNvOyiMfhZBbtjbZ1A PuVSwNXHvGbMPQUD3xpZ+Qhhmh2ZIWLCwohFHO7CejeD07F+B9ufkxzVQfgTeUt/BHGHcKKHW iBdaddWgIstEm8G/nFUcxD/tSAeBF9ixKnCFSDlZ9IOAFgUHG7yCBlJNR8fOm1P1KMSpdIUJ1 ZgufuKkZ/fpk+Y3C8JThZ/cNd3VuTgcItkVM4M83kvjvAYmARhChDiBEy2reyXlYHrHKjO+4H I4qxz4V7hms/Xrgvqx4UXp4WxkJjEpsSq/N85EVmsnil5KhguVcJmG8vQhxK+sL7cgJk0eobp suyNZ8XjqIo2uzrXwS8WTPaAveUOzKwPbPHWXEZ5WT9UxU/v+PIhRdMVmQyR+7OKEhOSNMjJ1 TG1JFIZm7s6lajR0+GIAbUkM3Wb092dzpmS+JSvpqnXEFl7R3zVxp0h1bCQZT4bO5UJ4rAx+g 2xQ2Dm2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 4 Sep 2016 17:28:13 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/x86/events/intel/cqm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/intel/cqm.c b/arch/x86/events/intel/cqm.c index 783c49d..ec61522 100644 --- a/arch/x86/events/intel/cqm.c +++ b/arch/x86/events/intel/cqm.c @@ -1651,8 +1651,9 @@ static int intel_mbm_init(void) goto out; } - array_size = sizeof(struct hrtimer) * mbm_socket_max; - mbm_timers = kmalloc(array_size, GFP_KERNEL); + mbm_timers = kmalloc_array(mbm_socket_max, + sizeof(*mbm_timers), + GFP_KERNEL); if (!mbm_timers) { ret = -ENOMEM; goto out; -- 2.9.3