From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933184AbcHYJXi (ORCPT ); Thu, 25 Aug 2016 05:23:38 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:6668 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932180AbcHYJXg (ORCPT ); Thu, 25 Aug 2016 05:23:36 -0400 Subject: Re: [PATCH 5/6] f2fs: enable inline_dentry by default To: Jaegeuk Kim References: <20160509115635.123946-1-yuchao0@huawei.com> <20160509115635.123946-5-yuchao0@huawei.com> <20160509230451.GB7448@jaegeuk.gateway> <0eea4e00-aa6a-8ea0-db9e-3d289c7fb20b@huawei.com> <20160823165717.GB73835@jaegeuk> CC: , From: Chao Yu Message-ID: Date: Thu, 25 Aug 2016 17:23:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160823165717.GB73835@jaegeuk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.57BEB90E.00A5,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 0b65c8667bf87e4ec7d48bb5c63805fa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2016/8/24 0:57, Jaegeuk Kim wrote: > Hi Chao, > > On Mon, Aug 22, 2016 at 09:49:13AM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/5/10 7:04, Jaegeuk Kim wrote: >>> On Mon, May 09, 2016 at 07:56:34PM +0800, Chao Yu wrote: >>>> Make inline_dentry as default mount option to improve space usage and >>>> IO performance in scenario of numerous small directory. >>> >>> Hmm, I've not much tested this so far. >>> Let me take time to consider this for a while. >> >> IMO, this feature is almost stable since I fixed most of bugs which occurs >> during inline conversion. And now I enable this feature by default when I do the >> test with fstest suit and fsstress, I didn't find any more bugs reported by >> those test tools. >> >> How do you think of enabling inline_dentry by default now? > > Okay, let me start all my tests with this. :) Cool, thanks for your support. ;) Thanks, > >> >> Thanks, >> >>> >>> Thanks, >>> >>>> >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/super.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>>> index 28c8992..4a4f4bd 100644 >>>> --- a/fs/f2fs/super.c >>>> +++ b/fs/f2fs/super.c >>>> @@ -824,6 +824,7 @@ static void default_options(struct f2fs_sb_info *sbi) >>>> >>>> set_opt(sbi, BG_GC); >>>> set_opt(sbi, INLINE_DATA); >>>> + set_opt(sbi, INLINE_DENTRY); >>>> set_opt(sbi, EXTENT_CACHE); >>>> >>>> #ifdef CONFIG_F2FS_FS_XATTR >>>> -- >>>> 2.8.2.311.gee88674 >>> . >>> > > . >